chrome/browser/data_use_measurement/data_use_web_contents_observer.h - Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/data_use_measurement/data_use_web_contents_observer.h

Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome. (Closed)

Patch Set: Use emplace to insert; remove copy constructor Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/data_use_measurement/chrome_data_use_recorder.cc ('k') | chrome/browser/data_use_measurement/data_use_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/data_use_measurement/data_use_web_contents_observer.h

diff --git a/chrome/browser/data_use_measurement/data_use_web_contents_observer.h b/chrome/browser/data_use_measurement/data_use_web_contents_observer.h

index 978ec4733b5f1299a239d25e0171ab868fe4d0ef..ba8d7d240a9c35bc8f9670c88580de327d2c847c 100644

--- a/chrome/browser/data_use_measurement/data_use_web_contents_observer.h

+++ b/chrome/browser/data_use_measurement/data_use_web_contents_observer.h

@@ -39,12 +39,9 @@ class DataUseWebContentsObserver

content::NavigationHandle* navigation_handle) override;

void ReadyToCommitNavigation(

content::NavigationHandle* navigation_handle) override;

- void DidRedirectNavigation(

- content::NavigationHandle* navigation_handle) override;

private:

friend class content::WebContentsUserData<DataUseWebContentsObserver>;

DataUseWebContentsObserver(content::WebContents* web_contents,

ChromeDataUseAscriberService* service);

ChromeDataUseAscriberService* const service_;