[inspector] use OS independent number to string conversion

[inspector] use OS independent number to string conversion

V8 internally uses conversions.h to convert number to string, we can use these methods too instead of slow std::stringstream with std::locale.

BUG=chromium:661497, v8:5551
R=dgozman@chromium.org

Committed: https://crrev.com/89d050c066f3d3e53d3a33b2ba0064a9684b9986
Cr-Commit-Position: refs/heads/master@{#41334}

[kozy, 2016-11-28 23:08:56]

Dmitry, please take a look.

[alph, 2016-11-28 23:10:14]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-11-28 23:10:15]

https://codereview.chromium.org/2534013002/diff/1/src/inspector/string-16.cc
File src/inspector/string-16.cc (right):

https://codereview.chromium.org/2534013002/diff/1/src/inspector/string-16.cc#...
src/inspector/string-16.cc:375: return fromInteger(static_cast<int>(number));
dead code below?

[kozy, 2016-11-28 23:12:45]

https://codereview.chromium.org/2534013002/diff/1/src/inspector/string-16.cc
File src/inspector/string-16.cc (right):

https://codereview.chromium.org/2534013002/diff/1/src/inspector/string-16.cc#...
src/inspector/string-16.cc:375: return fromInteger(static_cast<int>(number));
On 2016/11/28 23:10:15, alph wrote:
> dead code below?

good catch, removed this line.

[alph, 2016-11-28 23:40:28]

lgtm

https://codereview.chromium.org/2534013002/diff/20001/src/inspector/string-16.cc
File src/inspector/string-16.cc (right):

https://codereview.chromium.org/2534013002/diff/20001/src/inspector/string-16...
src/inspector/string-16.cc:367: const size_t kBufferSize = 50;
nit: no need to declare a const if it used once in an obvious way on the next
line.

https://codereview.chromium.org/2534013002/diff/20001/src/inspector/string-16...
src/inspector/string-16.cc:387: const size_t kBufferSize = 50;
ditto

[kozy, 2016-11-28 23:45:21]

all done, thanks!

https://codereview.chromium.org/2534013002/diff/20001/src/inspector/string-16.cc
File src/inspector/string-16.cc (right):

https://codereview.chromium.org/2534013002/diff/20001/src/inspector/string-16...
src/inspector/string-16.cc:367: const size_t kBufferSize = 50;
On 2016/11/28 23:40:28, alph wrote:
> nit: no need to declare a const if it used once in an obvious way on the next
> line.

Done.

https://codereview.chromium.org/2534013002/diff/20001/src/inspector/string-16...
src/inspector/string-16.cc:387: const size_t kBufferSize = 50;
On 2016/11/28 23:40:28, alph wrote:
> ditto

Done.

[kozy, 2016-11-28 23:45:25]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 23:45:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:12:07]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-11-29 00:31:51]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-29 00:31:51]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2534013002/#ps40001
(title: "inlined constant")

[commit-bot: I haz the power, 2016-11-29 00:31:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:34:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480379511164310,
"parent_rev": "50ef4a4033bb8fc60774e33407ff0a80e0f6ef89", "commit_rev":
"1a25f35746e5b310882fc85a8aa8a5ba15f46690"}

[commit-bot: I haz the power, 2016-11-29 00:34:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 00:34:44]

Description was changed from

==========
[inspector] use OS independent number to string conversion

V8 internally uses conversions.h to convert number to string, we can use these
methods too instead of slow std::stringstream with std::locale.

BUG=chromium:661497,v8:5551
R=dgozman@chromium.org
==========

to

==========
[inspector] use OS independent number to string conversion

V8 internally uses conversions.h to convert number to string, we can use these
methods too instead of slow std::stringstream with std::locale.

BUG=chromium:661497,v8:5551
R=dgozman@chromium.org

Committed: https://crrev.com/89d050c066f3d3e53d3a33b2ba0064a9684b9986
Cr-Commit-Position: refs/heads/master@{#41334}
==========

[commit-bot: I haz the power, 2016-11-29 00:34:45]

Patchset 3 (id:??) landed as
https://crrev.com/89d050c066f3d3e53d3a33b2ba0064a9684b9986
Cr-Commit-Position: refs/heads/master@{#41334}