Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2534003002: MD Settings: Add tooltip for Old Image in Change Picture. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add tooltip for Old Image in Change Picture. The tooltip is now "Existing photo from camera or file", as the code does not track where it came from. In the old Options version, it said "Photo from internal camera" in the first preview icon immediately after taking it, but not on subsequent openings of the dialog. BUG=666671 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/eab2da39cd9f081c229a29bdaa16fc95b967a10b Cr-Commit-Position: refs/heads/master@{#435328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
tommycli
stevenjb: PTAL screenshot in second image of this album: http://imgur.com/a/KSaaC
4 years ago (2016-11-28 23:40:40 UTC) #5
stevenjb
lgtm
4 years ago (2016-11-29 20:21:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534003002/1
4 years ago (2016-11-30 15:41:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 18:00:35 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-30 18:05:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eab2da39cd9f081c229a29bdaa16fc95b967a10b
Cr-Commit-Position: refs/heads/master@{#435328}

Powered by Google App Engine
This is Rietveld 408576698