Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2533983003:
Move hacks for Inspector in restoreCachedResourceIfNeeded() to ResourceFetcher (Closed)
|
Created:
4 years ago by hiroshige Modified:
3 years, 11 months ago CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-css, Yoav Weiss, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove hacks for Inspector in restoreCachedResourceIfNeeded() to ResourceFetcher
This CL moves the hacks for Inspector in:
- CSSFontFaceSrcValue::restoreCachedResourceIfNeeded()
- CSSImageValue::restoreCachedResourceIfNeeded()
to ResourceFetcher, in order to
- centralize the workaround and
- prevent core/css from directly touching ImageResource objects
(as preparation for Issue 667641).
This CL replaces MixedContentChecker::shouldBlockFetch() calls with
FetchContext::canRequest() (that calls shouldBlockFetch() inside it) to
prevent layering violation (MixedContentChecker cannot be called directly
from core/fetch).
BUG=666214, 667641
Committed: https://crrev.com/c53087f6e68fe790901cedf96ae37e696d613848
Cr-Commit-Position: refs/heads/master@{#436877}
Patch Set 1 #Patch Set 2 : Font #Patch Set 3 : Make requestLoadStarted() private #Patch Set 4 : Rebase #Patch Set 5 : Rebase #
Total comments: 2
Patch Set 6 : dcheck #Patch Set 7 : Rebase #Patch Set 8 : Rebase #Patch Set 9 : Rebase #
Messages
Total messages: 47 (36 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Refactor hacks for Inspector in CSSImageValue::restoreCachedResourceIfNeeded() BUG= ========== to ========== Refactor hacks for Inspector in restoreCachedResourceIfNeeded() CSSImageValue::restoreCachedResourceIfNeeded() BUG= ==========
Description was changed from ========== Refactor hacks for Inspector in restoreCachedResourceIfNeeded() CSSImageValue::restoreCachedResourceIfNeeded() BUG= ========== to ========== Move hacks for Inspector in restoreCachedResourceIfNeeded() to ResourceFetcher This CL moves the hacks for Inspector in: - CSSFontFaceSrcValue::restoreCachedResourceIfNeeded() - CSSImageValue::restoreCachedResourceIfNeeded() to ResourceFetcher, in order to - centralize the workaround and - prevent core/css from directly touching ImageResource objects (as preparation for Issue 667641). This CL replaces MixedContentChecker::shouldBlockFetch() calls with FetchContext::canRequest() (that calls shouldBlockFetch() inside it) to prevent layering violation (MixedContentChecker cannot be called directly from core/fetch). BUG=666214, 667641 ==========
hiroshige@chromium.org changed reviewers: + japhet@chromium.org, tasak@google.com, yhirano@chromium.org
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2533983003/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp (left): https://codereview.chromium.org/2533983003/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp:123: request.setContentSecurityCheck(m_shouldCheckContentSecurityPolicy); This statement is missing in the new code.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2533983003/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp (left): https://codereview.chromium.org/2533983003/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp:123: request.setContentSecurityCheck(m_shouldCheckContentSecurityPolicy); On 2016/12/01 10:44:23, yhirano wrote: > This statement is missing in the new code. I expected m_shouldCheckContentSecurityPolicy == m_fetched->resource()->options().contentSecurityPolicyOption, and the flag is set via the ResourceLoaderOptions at the line: > FetchRequest request(resourceRequest, initiatorName, resource->options()); I added a DCHECK() to confirm this.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
drive-by lgtm
lgtm
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org, tyoshino@chromium.org, japhet@chromium.org Link to the patchset: https://codereview.chromium.org/2533983003/#ps160001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for sharing this valuable code.It helped me a lot. Waiting for this type of valuable code. I am a writer of essay writing service reviews. You can contact http://essaywriting-servicereviews.com/ for any writing help.
CQ is committing da patch.
Bot data: {"patchset_id": 160001, "attempt_start_ts": 1481084930640270,
"parent_rev": "3656764b846866ee79c167905f46438b7e2dab1d", "commit_rev":
"9957fe94fa47d05cf663b031f138dbf4f176859b"}
Message was sent while issue was closed.
Description was changed from ========== Move hacks for Inspector in restoreCachedResourceIfNeeded() to ResourceFetcher This CL moves the hacks for Inspector in: - CSSFontFaceSrcValue::restoreCachedResourceIfNeeded() - CSSImageValue::restoreCachedResourceIfNeeded() to ResourceFetcher, in order to - centralize the workaround and - prevent core/css from directly touching ImageResource objects (as preparation for Issue 667641). This CL replaces MixedContentChecker::shouldBlockFetch() calls with FetchContext::canRequest() (that calls shouldBlockFetch() inside it) to prevent layering violation (MixedContentChecker cannot be called directly from core/fetch). BUG=666214, 667641 ========== to ========== Move hacks for Inspector in restoreCachedResourceIfNeeded() to ResourceFetcher This CL moves the hacks for Inspector in: - CSSFontFaceSrcValue::restoreCachedResourceIfNeeded() - CSSImageValue::restoreCachedResourceIfNeeded() to ResourceFetcher, in order to - centralize the workaround and - prevent core/css from directly touching ImageResource objects (as preparation for Issue 667641). This CL replaces MixedContentChecker::shouldBlockFetch() calls with FetchContext::canRequest() (that calls shouldBlockFetch() inside it) to prevent layering violation (MixedContentChecker cannot be called directly from core/fetch). BUG=666214, 667641 ==========
Message was sent while issue was closed.
Committed patchset #9 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Move hacks for Inspector in restoreCachedResourceIfNeeded() to ResourceFetcher This CL moves the hacks for Inspector in: - CSSFontFaceSrcValue::restoreCachedResourceIfNeeded() - CSSImageValue::restoreCachedResourceIfNeeded() to ResourceFetcher, in order to - centralize the workaround and - prevent core/css from directly touching ImageResource objects (as preparation for Issue 667641). This CL replaces MixedContentChecker::shouldBlockFetch() calls with FetchContext::canRequest() (that calls shouldBlockFetch() inside it) to prevent layering violation (MixedContentChecker cannot be called directly from core/fetch). BUG=666214, 667641 ========== to ========== Move hacks for Inspector in restoreCachedResourceIfNeeded() to ResourceFetcher This CL moves the hacks for Inspector in: - CSSFontFaceSrcValue::restoreCachedResourceIfNeeded() - CSSImageValue::restoreCachedResourceIfNeeded() to ResourceFetcher, in order to - centralize the workaround and - prevent core/css from directly touching ImageResource objects (as preparation for Issue 667641). This CL replaces MixedContentChecker::shouldBlockFetch() calls with FetchContext::canRequest() (that calls shouldBlockFetch() inside it) to prevent layering violation (MixedContentChecker cannot be called directly from core/fetch). BUG=666214, 667641 Committed: https://crrev.com/c53087f6e68fe790901cedf96ae37e696d613848 Cr-Commit-Position: refs/heads/master@{#436877} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/c53087f6e68fe790901cedf96ae37e696d613848 Cr-Commit-Position: refs/heads/master@{#436877}
Message was sent while issue was closed.
On 2016/12/07 04:46:18, annmariya wrote: > Thanks for sharing this valuable code.It helped me a lot. Waiting for this type > of valuable code. I am a writer of essay writing service reviews. You can > contact us for any writing help. Hey! everyone here knows, that any student or just human can get any help, connected with writing, coding or feeling alone at https://writingsguru.com |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
