Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2533963002: [chromedriver] Return not-implemented status code for FullscreenWindow command. (Closed)

Created:
4 years ago by gmanikpure
Modified:
4 years ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Return not-implemented status code for FullscreenWindow command. BUG=chromedriver:1617 Committed: https://crrev.com/50c9dd90b42ae759eb63656b5a50d87262318a8f Cr-Commit-Position: refs/heads/master@{#435068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/test/chromedriver/server/http_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
gmanikpure
Hi Sam, Could you please take a look whenever time permits? Thanks
4 years ago (2016-11-28 21:02:48 UTC) #2
samuong
lgtm
4 years ago (2016-11-29 19:35:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533963002/1
4 years ago (2016-11-29 20:02:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 20:25:22 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 20:29:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50c9dd90b42ae759eb63656b5a50d87262318a8f
Cr-Commit-Position: refs/heads/master@{#435068}

Powered by Google App Engine
This is Rietveld 408576698