net/log/trace_constants.h - Issue 2533953005: Standardize "net" category trace events

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/log/trace_constants.h

Issue 2533953005: Standardize "net" category trace events (Closed)

Patch Set: self review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NET_LOG_TRACE_CONSTANTS_H_
	mmenke 2016/12/01 16:16:14 We aren't consistent about it, but this should pro We aren't consistent about it, but this should probably be in net/base (To avoid circular dependencies, at the directory level. We do have a lot of them already, but no reason to add another unless we get something from it) xunjieli 2016/12/01 23:38:11 Done. Show quoted text On 2016/12/01 16:16:14, mmenke wrote: > We aren't consistent about it, but this should probably be in net/base (To avoid > circular dependencies, at the directory level. We do have a lot of them > already, but no reason to add another unless we get something from it) Done.
	6 #define NET_LOG_TRACE_CONSTANTS_H_

	7

	8 #include "net/base/net_export.h"

	9

	10 namespace net {

	11

	12 // Net Category used in Tracing.

	13 NET_EXPORT_PRIVATE extern const char kNetTracingCategory[];

	14

	15 } // namespace net

	16

	17 #endif // NET_LOG_TRACE_CONSTANTS_H_

OLD	NEW

« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/log/trace_constants.cc » ('j') | no next file with comments »