Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 253393006: WeakHashTable::Put() and callers handlified. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

WeakHashTable::Put() and callers handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20959

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M src/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M src/lithium-codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/objects.cc View 1 1 chunk +16 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
PTAL #10.
6 years, 8 months ago (2014-04-24 15:32:19 UTC) #1
Yang
lgtm with comments. https://codereview.chromium.org/253393006/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/253393006/diff/1/src/objects.cc#newcode16270 src/objects.cc:16270: Handle<Object> value) { This method cannot ...
6 years, 8 months ago (2014-04-25 07:32:26 UTC) #2
Igor Sheludko
https://codereview.chromium.org/253393006/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/253393006/diff/1/src/objects.cc#newcode16270 src/objects.cc:16270: Handle<Object> value) { On 2014/04/25 07:32:27, Yang wrote: > ...
6 years, 8 months ago (2014-04-25 08:10:33 UTC) #3
Igor Sheludko
6 years, 8 months ago (2014-04-25 08:10:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20959 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698