Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2533923002: Add a test for crbug.com/664887 (layout change with collapsed border) (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
wkorman
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for crbug.com/664887 (layout change with collapsed border) BUG=664887 Committed: https://crrev.com/0deb60dd3d3b6e0146beddd7dc47918ae0e8d62c Cr-Commit-Position: refs/heads/master@{#434767}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix border-collapse #

Patch Set 3 : Fix border-collapse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize-expected.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize-expected.txt View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Xianzhu
4 years ago (2016-11-28 19:28:29 UTC) #3
wkorman
https://codereview.chromium.org/2533923002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html File third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html (right): https://codereview.chromium.org/2533923002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html#newcode2 third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html:2: <table style="collapse-border: collapse"> Doesn't it have to be border-collapse: ...
4 years ago (2016-11-28 21:21:25 UTC) #5
Xianzhu
https://codereview.chromium.org/2533923002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html File third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html (right): https://codereview.chromium.org/2533923002/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html#newcode2 third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize.html:2: <table style="collapse-border: collapse"> On 2016/11/28 21:21:25, wkorman wrote: > ...
4 years ago (2016-11-28 21:34:01 UTC) #6
wkorman
lgtm
4 years ago (2016-11-28 21:35:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533923002/40001
4 years ago (2016-11-28 21:40:09 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-28 23:11:39 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 23:13:32 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0deb60dd3d3b6e0146beddd7dc47918ae0e8d62c
Cr-Commit-Position: refs/heads/master@{#434767}

Powered by Google App Engine
This is Rietveld 408576698