Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2533913003: Fix typo in enterVR failure case, causing incorrect VR exiting. (Closed)

Created:
4 years ago by mthiesse
Modified:
4 years ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in enterVR failure case, causing incorrect VR exiting. BUG=667444 Committed: https://crrev.com/8976c9ccfc0a6eadfdeca964beb69a64e516bfce Cr-Commit-Position: refs/heads/master@{#434780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mthiesse
PTAL
4 years ago (2016-11-28 20:32:38 UTC) #2
bshe
On 2016/11/28 20:32:38, mthiesse wrote: > PTAL lgtm
4 years ago (2016-11-28 21:54:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533913003/1
4 years ago (2016-11-28 22:11:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 23:52:13 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-28 23:54:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8976c9ccfc0a6eadfdeca964beb69a64e516bfce
Cr-Commit-Position: refs/heads/master@{#434780}

Powered by Google App Engine
This is Rietveld 408576698