Don't search if the driver cannot reference the element.

Don't search if the driver cannot reference the element.

This is just a performance optimization to avoid analyzing the element file in a driver that does not use the file yet.

We use library/unit URIs to search in index, so search in extra drivers would not produce extra results.


R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/d8ac1076d9ce831a0f1ba71847ae7824c77730a7

[Paul Berry, 2016-11-28 21:45:10]

Can we add a unit test to validate this behavior?

lgtm assuming a test is added.

https://codereview.chromium.org/2533853005/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/search.dart (right):

https://codereview.chromium.org/2533853005/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/search.dart:75: // If the file with the
element is not know, then the element is not used.
s/know/known/

[Paul Berry, 2016-11-28 21:47:05]

On 2016/11/28 21:45:10, Paul Berry wrote:
> Can we add a unit test to validate this behavior?
> 
> lgtm assuming a test is added.
> 
>
https://codereview.chromium.org/2533853005/diff/1/pkg/analyzer/lib/src/dart/a...
> File pkg/analyzer/lib/src/dart/analysis/search.dart (right):
> 
>
https://codereview.chromium.org/2533853005/diff/1/pkg/analyzer/lib/src/dart/a...
> pkg/analyzer/lib/src/dart/analysis/search.dart:75: // If the file with the
> element is not know, then the element is not used.
> s/know/known/

Sorry, I misunderstood--it turns out this is just a performance optimization.

Would you mind adding a quick comment to the CL description saying so?  With
that, lgtm.

[Brian Wilkerson, 2016-11-28 21:47:55]

lgtm

[scheglov, 2016-11-28 21:49:23]

Description was changed from

==========
Don't search if the driver cannot reference the element.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Don't search if the driver cannot reference the element.

This is just a performance optimization to avoid analyzing the element file in a
driver that does not use the file yet.

We use library/unit URIs to search in index, so search in extra drivers would
not produce extra results.


R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

[scheglov, 2016-11-28 21:51:39]

Description was changed from

==========
Don't search if the driver cannot reference the element.

This is just a performance optimization to avoid analyzing the element file in a
driver that does not use the file yet.

We use library/unit URIs to search in index, so search in extra drivers would
not produce extra results.


R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Don't search if the driver cannot reference the element.

This is just a performance optimization to avoid analyzing the element file in a
driver that does not use the file yet.

We use library/unit URIs to search in index, so search in extra drivers would
not produce extra results.


R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/d8ac1076d9ce831a0f1ba71847ae7824c77730a7
==========

[scheglov, 2016-11-28 21:51:41]

Committed patchset #1 (id:1) manually as
d8ac1076d9ce831a0f1ba71847ae7824c77730a7 (presubmit successful).