Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2533853003: Reland of Disable Precompile-platform with clang-cl. (Closed)

Created:
4 years ago by Reid Kleckner
Modified:
4 years ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable Precompile-platform with clang-cl. (patchset #1 id:1 of https://codereview.chromium.org/2526383002/ ) Reason for revert: Clang still asserts when building Precompile-core.obj, but it's somewhere else: Assertion failed: AllowUnresolvedNodes && "Cannot handle unresolved nodes"... Original issue's description: > Revert of Disable Precompile-platform with clang-cl. (patchset #1 id:1 of https://codereview.chromium.org/2520833005/ ) > > Reason for revert: > The crash is now hopefully fixed in clang-cl. > > Original issue's description: > > Disable Precompile-platform with clang-cl. > > > > It currently asserts while trying to build that PCH file. > > > > BUG=667891, 495697 > > NOTRY=true > > > > Committed: https://crrev.com/5b7b04e7fa59d53b8b7917d4c0cf4081abdfb0e3 > > Cr-Commit-Position: refs/heads/master@{#434028} > > TBR=rnk@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=667891, 495697 > > Committed: https://crrev.com/a0eb8ed36a1c3e2c5becc95ef03d42655c7cd95c > Cr-Commit-Position: refs/heads/master@{#434534} TBR=thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=667891, 495697 Committed: https://crrev.com/c43462be8948e6a3a1c9a7d6bc6b10fc5fc789b8 Cr-Commit-Position: refs/heads/master@{#434737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Reid Kleckner
Created Reland of Disable Precompile-platform with clang-cl.
4 years ago (2016-11-28 19:57:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533853003/1
4 years ago (2016-11-28 19:59:06 UTC) #3
Nico
lgtm, thanks The bots on tot (https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dbg%29 etc) are all happy -- any idea what ...
4 years ago (2016-11-28 20:01:16 UTC) #4
Nico
Also, the thing you're reverting was for platform while your cl is for core (?)
4 years ago (2016-11-28 20:01:46 UTC) #5
Reid Kleckner
On 2016/11/28 20:01:46, Nico wrote: > Also, the thing you're reverting was for platform while ...
4 years ago (2016-11-28 20:46:23 UTC) #6
Reid Kleckner
On 2016/11/28 20:01:16, Nico wrote: > lgtm, thanks > > The bots on tot > ...
4 years ago (2016-11-28 20:47:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 22:27:28 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c43462be8948e6a3a1c9a7d6bc6b10fc5fc789b8 Cr-Commit-Position: refs/heads/master@{#434737}
4 years ago (2016-11-28 22:30:03 UTC) #12
Nico
4 years ago (2016-12-05 20:09:53 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2551213002/ by thakis@chromium.org.

The reason for reverting is: This should work after yesterday's clang roll. We
now have a bot that builds with symbols, and I was able to build blink_tests
with symbols locally with this reverted locally..

Powered by Google App Engine
This is Rietveld 408576698