[build] Use MSVS 2015 by default.

[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y

Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Committed: https://crrev.com/c71fc9902d5f6b2cf6beedde52e44a391b856c19
Cr-Original-Commit-Position: refs/heads/master@{#41407}
Cr-Commit-Position: refs/heads/master@{#41410}

[Michael Achenbach, 2016-11-28 14:46:11]

Description was changed from

==========
[build] Use MSVS 2015 by default.

BUG=
==========

to

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y
==========

[Michael Achenbach, 2016-11-30 19:12:18]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 19:12:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-11-30 19:23:18]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-11-30 19:23:19]

PTAL

https://codereview.chromium.org/2533813002/diff/80001/DEPS
File DEPS (left):

https://codereview.chromium.org/2533813002/diff/80001/DEPS#oldcode266
DEPS:266: 'action': ['python', 'v8/gypfiles/vs_toolchain.py', 'update'],
Will remove this file in a follow up if this sticks.

https://codereview.chromium.org/2533813002/diff/80001/gypfiles/win/msvs_depen...
File gypfiles/win/msvs_dependencies.isolate (right):

https://codereview.chromium.org/2533813002/diff/80001/gypfiles/win/msvs_depen...
gypfiles/win/msvs_dependencies.isolate:5: # TODO(machenbach): Remove this when
crbug.com/669910 is resolved.
Fork of the file in chromium without the x64 subdirectories:
https://cs.chromium.org/chromium/src/build/config/win/msvs_dependencies.isolate

They make things fail and seem to be legacy as they don't exist in the GN/MB
version:
https://cs.chromium.org/chromium/src/base/BUILD.gn?q=api-ms-win-core-console-...

Added this todo to migrate to the GN/MB version in a follow up effort. But
that's a bit more complex.

https://codereview.chromium.org/2533813002/diff/80001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2533813002/diff/80001/tools/mb/mb.py#newcode781
tools/mb/mb.py:781: # TODO(machenbach): Remove after GYP_MSVS_VERSION is removed
on infra side.
As soon as this sticks, I'll remove the GYP_MSVS_VERSION=2013 environment
variables on the infra side.

[commit-bot: I haz the power, 2016-11-30 19:50:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 19:50:50]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-12-01 08:14:15]

lgtm

[Michael Achenbach, 2016-12-01 08:14:35]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-12-01 08:14:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 08:16:18]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480580075182310,
"parent_rev": "36732d5be43b47261b313d7d9dd5667177606e4c", "commit_rev":
"2a2dd6ff4920bfb0809550083a21968dc7e551bd"}

[commit-bot: I haz the power, 2016-12-01 08:16:23]

Description was changed from

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y
==========

to

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y
==========

[commit-bot: I haz the power, 2016-12-01 08:16:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-01 08:16:35]

Description was changed from

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y
==========

to

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y

Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Cr-Commit-Position: refs/heads/master@{#41407}
==========

[commit-bot: I haz the power, 2016-12-01 08:16:36]

Patchset 5 (id:??) landed as
https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Cr-Commit-Position: refs/heads/master@{#41407}

[Michael Achenbach, 2016-12-01 08:34:56]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2538493007/ by machenbach@chromium.org.

The reason for reverting is: Breaks CI dbg builder:
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20buil....

[Michael Achenbach, 2016-12-01 08:48:24]

Revert was unnecessary. This was just http://crbug.com/662325

https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20buil...

We just need to wait until the new toolchain is available on all bots. This
might cause a few spurious errors.

Will reland this.

[Michael Achenbach, 2016-12-01 08:48:32]

Description was changed from

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y

Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Cr-Commit-Position: refs/heads/master@{#41407}
==========

to

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y

Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Cr-Commit-Position: refs/heads/master@{#41407}
==========

[Michael Achenbach, 2016-12-01 08:48:37]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-12-01 08:48:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 08:50:28]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480582117099060,
"parent_rev": "f750f00289c29814a35acbd22b575ebc9cb8757e", "commit_rev":
"4f51deef0b6cf07f72815241693730f821e7b175"}

[commit-bot: I haz the power, 2016-12-01 08:50:32]

Description was changed from

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y

Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Cr-Commit-Position: refs/heads/master@{#41407}
==========

to

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y

Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Cr-Commit-Position: refs/heads/master@{#41407}
==========

[commit-bot: I haz the power, 2016-12-01 08:50:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-01 08:51:05]

Description was changed from

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y

Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Cr-Commit-Position: refs/heads/master@{#41407}
==========

to

==========
[build] Use MSVS 2015 by default.

BUG=chromium:603131
LOG=y

Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Committed: https://crrev.com/c71fc9902d5f6b2cf6beedde52e44a391b856c19
Cr-Original-Commit-Position: refs/heads/master@{#41407}
Cr-Commit-Position: refs/heads/master@{#41410}
==========

[commit-bot: I haz the power, 2016-12-01 08:51:06]

Patchset 5 (id:??) landed as
https://crrev.com/c71fc9902d5f6b2cf6beedde52e44a391b856c19
Cr-Commit-Position: refs/heads/master@{#41410}