Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years ago by Michael Achenbach Modified:
4 years ago Reviewers:
jochen (gone - plz use gerrit), vogelheim CC:
v8-reviews_googlegroups.com, brucedawson Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[build] Use MSVS 2015 by default.
BUG=chromium:603131
LOG=y
Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac
Committed: https://crrev.com/c71fc9902d5f6b2cf6beedde52e44a391b856c19
Cr-Original-Commit-Position: refs/heads/master@{#41407}
Cr-Commit-Position: refs/heads/master@{#41410}
Patch Set 1 #Patch Set 2 : Add msvs deps #Patch Set 3 : dlls #Patch Set 4 : fork win deps #Patch Set 5 : Add todos #
Total comments: 3
Created: 4 years ago
Messages
Total messages: 25 (15 generated)
Description was changed from ========== [build] Use MSVS 2015 by default. BUG= ========== to ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
PTAL https://codereview.chromium.org/2533813002/diff/80001/DEPS File DEPS (left): https://codereview.chromium.org/2533813002/diff/80001/DEPS#oldcode266 DEPS:266: 'action': ['python', 'v8/gypfiles/vs_toolchain.py', 'update'], Will remove this file in a follow up if this sticks. https://codereview.chromium.org/2533813002/diff/80001/gypfiles/win/msvs_depen... File gypfiles/win/msvs_dependencies.isolate (right): https://codereview.chromium.org/2533813002/diff/80001/gypfiles/win/msvs_depen... gypfiles/win/msvs_dependencies.isolate:5: # TODO(machenbach): Remove this when crbug.com/669910 is resolved. Fork of the file in chromium without the x64 subdirectories: https://cs.chromium.org/chromium/src/build/config/win/msvs_dependencies.isolate They make things fail and seem to be legacy as they don't exist in the GN/MB version: https://cs.chromium.org/chromium/src/base/BUILD.gn?q=api-ms-win-core-console-... Added this todo to migrate to the GN/MB version in a follow up effort. But that's a bit more complex. https://codereview.chromium.org/2533813002/diff/80001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2533813002/diff/80001/tools/mb/mb.py#newcode781 tools/mb/mb.py:781: # TODO(machenbach): Remove after GYP_MSVS_VERSION is removed on infra side. As soon as this sticks, I'll remove the GYP_MSVS_VERSION=2013 environment variables on the infra side.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480580075182310,
"parent_rev": "36732d5be43b47261b313d7d9dd5667177606e4c", "commit_rev":
"2a2dd6ff4920bfb0809550083a21968dc7e551bd"}
Message was sent while issue was closed.
Description was changed from ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y ========== to ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y ========== to ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Cr-Commit-Position: refs/heads/master@{#41407} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Cr-Commit-Position: refs/heads/master@{#41407}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2538493007/ by machenbach@chromium.org. The reason for reverting is: Breaks CI dbg builder: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20buil....
Message was sent while issue was closed.
Revert was unnecessary. This was just http://crbug.com/662325 https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20buil... We just need to wait until the new toolchain is available on all bots. This might cause a few spurious errors. Will reland this.
Message was sent while issue was closed.
Description was changed from ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Cr-Commit-Position: refs/heads/master@{#41407} ========== to ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Cr-Commit-Position: refs/heads/master@{#41407} ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480582117099060,
"parent_rev": "f750f00289c29814a35acbd22b575ebc9cb8757e", "commit_rev":
"4f51deef0b6cf07f72815241693730f821e7b175"}
Message was sent while issue was closed.
Description was changed from ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Cr-Commit-Position: refs/heads/master@{#41407} ========== to ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Cr-Commit-Position: refs/heads/master@{#41407} ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Cr-Commit-Position: refs/heads/master@{#41407} ========== to ========== [build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Committed: https://crrev.com/c71fc9902d5f6b2cf6beedde52e44a391b856c19 Cr-Original-Commit-Position: refs/heads/master@{#41407} Cr-Commit-Position: refs/heads/master@{#41410} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/c71fc9902d5f6b2cf6beedde52e44a391b856c19 Cr-Commit-Position: refs/heads/master@{#41410} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
