[parser] removed undefined check of for-of iterator

[parser] removed redundant undefined check of for-of iterator

Removed a redundant check: If completion is not normal, then #iterator cannot be undefined.

Committed: https://crrev.com/08931d45ba023bc7d4748469beba25fe9e7d0132
Cr-Commit-Position: refs/heads/master@{#41321}

[Tobias Tebbi, 2016-11-28 14:26:01]

The CQ bit was checked by tebbi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 14:26:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tobias Tebbi, 2016-11-28 14:31:32]

Description was changed from

==========
[parser] removed undefined check of for-of iterator

BUG=
==========

to

==========
[parser] removed redundant undefined check of for-of iterator

Removed a redundant check: If completion is not normal, then #iterator cannot be
undefined.
==========

[Tobias Tebbi, 2016-11-28 14:31:32]

tebbi@chromium.org changed reviewers:
+ neis@chromium.org

[commit-bot: I haz the power, 2016-11-28 14:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 14:39:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Tobias Tebbi, 2016-11-28 14:47:00]

The CQ bit was checked by tebbi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 14:47:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-11-28 14:52:50]

neis@chromium.org changed reviewers:
+ rossberg@chromium.org

[neis, 2016-11-28 14:52:51]

Thank! lgtm modulo comment.  +rossberg since I'm not a parsing owner and since
he originally committed this code.

https://codereview.chromium.org/2533803002/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2533803002/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:5434: //     if (!(completion === kNormalCompletion)) {
See below.

https://codereview.chromium.org/2533803002/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:5451: closing_condition =
factory()->NewUnaryOperation(Token::NOT, cmp, nopos);
You can use NE_STRICT (!==) instead of negating EQ_STRICT.

[rossberg, 2016-11-28 15:00:27]

lgtm

[commit-bot: I haz the power, 2016-11-28 15:11:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 15:11:35]

Dry run: This issue passed the CQ dry run.

[Tobias Tebbi, 2016-11-28 15:27:17]

On 2016/11/28 14:52:51, neis wrote:
> Thank! lgtm modulo comment.  +rossberg since I'm not a parsing owner and since
> he originally committed this code.
> 
> https://codereview.chromium.org/2533803002/diff/20001/src/parsing/parser.cc
> File src/parsing/parser.cc (right):
> 
>
https://codereview.chromium.org/2533803002/diff/20001/src/parsing/parser.cc#n...
> src/parsing/parser.cc:5434: //     if (!(completion === kNormalCompletion)) {
> See below.
> 
>
https://codereview.chromium.org/2533803002/diff/20001/src/parsing/parser.cc#n...
> src/parsing/parser.cc:5451: closing_condition =
> factory()->NewUnaryOperation(Token::NOT, cmp, nopos);
> You can use NE_STRICT (!==) instead of negating EQ_STRICT.

Ignition doesn't implement NE_STRICT.

[Tobias Tebbi, 2016-11-28 15:28:19]

The CQ bit was checked by tebbi@chromium.org

[commit-bot: I haz the power, 2016-11-28 15:28:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 15:30:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480346899117880,
"parent_rev": "b66a75376800533605d42a66cdcb488f30790c0b", "commit_rev":
"13a6f9f4c056512e23e0010384b590620f66a9da"}

[commit-bot: I haz the power, 2016-11-28 15:30:05]

Description was changed from

==========
[parser] removed redundant undefined check of for-of iterator

Removed a redundant check: If completion is not normal, then #iterator cannot be
undefined.
==========

to

==========
[parser] removed redundant undefined check of for-of iterator

Removed a redundant check: If completion is not normal, then #iterator cannot be
undefined.
==========

[commit-bot: I haz the power, 2016-11-28 15:30:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 15:30:23]

Description was changed from

==========
[parser] removed redundant undefined check of for-of iterator

Removed a redundant check: If completion is not normal, then #iterator cannot be
undefined.
==========

to

==========
[parser] removed redundant undefined check of for-of iterator

Removed a redundant check: If completion is not normal, then #iterator cannot be
undefined.

Committed: https://crrev.com/08931d45ba023bc7d4748469beba25fe9e7d0132
Cr-Commit-Position: refs/heads/master@{#41321}
==========

[commit-bot: I haz the power, 2016-11-28 15:30:24]

Patchset 2 (id:??) landed as
https://crrev.com/08931d45ba023bc7d4748469beba25fe9e7d0132
Cr-Commit-Position: refs/heads/master@{#41321}