Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2533793005: Check that invocations have well-formed targets in kernel verifier. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check that invocations have well-formed targets in kernel verifier. This also fixes some issues in the frontend and transformers that generated calls without the correct number of type arguments. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/440813c67b2d6bc3e9cbd06acfc38a5aee3fe9e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -5 lines) Patch
M pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/kernel/lib/transformations/continuation.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/kernel/lib/transformations/mixin_full_resolution.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/kernel/lib/verifier.dart View 1 chunk +141 lines, -0 lines 0 comments Download
M pkg/kernel/test/verify_test.dart View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
4 years ago (2016-11-29 17:03:24 UTC) #3
Kevin Millikin (Google)
LGTM.
4 years ago (2016-11-30 07:16:37 UTC) #4
asgerf
4 years ago (2016-11-30 07:24:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
440813c67b2d6bc3e9cbd06acfc38a5aee3fe9e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698