Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 2533793004: Reset settings button when update the list view. (Closed)

Created:
4 years ago by tdanderson
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Reset settings button when update the list view. We need to reset the settings button object when updating the IME detailed view, otherwise there may has memory leak, and checking if(settings_button_) could be true but the IME view is updated without drawing the settings button. BUG=667105 TEST=Verified on Clapper. Review-Url: https://codereview.chromium.org/2521443002 Cr-Commit-Position: refs/heads/master@{#434083} (cherry picked from commit 4ac84d7c1ef8eb9c8d1ab59608975de1db3c7821) Committed: https://chromium.googlesource.com/chromium/src/+/6cf3948a71dbb62220c262d1d98b9e378efa46da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_list_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tdanderson
4 years ago (2016-11-28 21:29:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cf3948a71dbb62220c262d1d98b9e378efa46da.

Powered by Google App Engine
This is Rietveld 408576698