Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2533783003: Add metrics for style update time before FCP. (Closed)
Patch Set: value_or(base::TimeDelta()) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index f7333bed0aba9fe5a2af9a75e979f3b7b9bed805..8e4f24a297f0a38fbc66d7096cdb004fc364298a 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -345,6 +345,21 @@ void CorePageLoadMetricsObserver::OnFirstContentfulPaint(
timing.style_sheet_timing.author_style_sheet_parse_duration_before_fcp
.value());
}
+ if (timing.style_sheet_timing.update_style_duration_before_fcp) {
+ PAGE_LOAD_HISTOGRAM(
+ "PageLoad.CSSTiming.Update.BeforeFirstContentfulPaint",
+ timing.style_sheet_timing.update_style_duration_before_fcp.value());
+ }
+ if (timing.style_sheet_timing
+ .author_style_sheet_parse_duration_before_fcp ||
+ timing.style_sheet_timing.update_style_duration_before_fcp) {
+ PAGE_LOAD_HISTOGRAM(
+ "PageLoad.CSSTiming.ParseAndUpdate.BeforeFirstContentfulPaint",
+ timing.style_sheet_timing.author_style_sheet_parse_duration_before_fcp
+ .value_or(base::TimeDelta()) +
+ timing.style_sheet_timing.update_style_duration_before_fcp
+ .value_or(base::TimeDelta()));
+ }
switch (GetPageLoadType(transition_)) {
case LOAD_TYPE_RELOAD:
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698