chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc - Issue 2533783003: Add metrics for style update time before FCP.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2533783003: Add metrics for style update time before FCP. (Closed)

Patch Set: value_or(base::TimeDelta()) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | chrome/common/page_load_metrics/page_load_metrics_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/files/scoped_temp_dir.h"	5 #include "base/files/scoped_temp_dir.h"

6 #include "base/macros.h"	6 #include "base/macros.h"

7 #include "base/test/histogram_tester.h"	7 #include "base/test/histogram_tester.h"

8 #include "base/time/time.h"	8 #include "base/time/time.h"

9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"	9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"

10 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"	10 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"

(...skipping 534 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
545 // unset here.	545 // unset here.

546 ui_test_utils::NavigateToURL(	546 ui_test_utils::NavigateToURL(

547 browser(),	547 browser(),

548 embedded_test_server()->GetURL("/page_load_metrics/page_with_css.html"));	548 embedded_test_server()->GetURL("/page_load_metrics/page_with_css.html"));

549 NavigateToUntrackedUrl();	549 NavigateToUntrackedUrl();

550	550

551 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstContentfulPaint,	551 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstContentfulPaint,

552 1);	552 1);

553 histogram_tester_.ExpectTotalCount(	553 histogram_tester_.ExpectTotalCount(

554 "PageLoad.CSSTiming.Parse.BeforeFirstContentfulPaint", 1);	554 "PageLoad.CSSTiming.Parse.BeforeFirstContentfulPaint", 1);

	555 histogram_tester_.ExpectTotalCount(

	556 "PageLoad.CSSTiming.Update.BeforeFirstContentfulPaint", 1);

	557 histogram_tester_.ExpectTotalCount(

	558 "PageLoad.CSSTiming.ParseAndUpdate.BeforeFirstContentfulPaint", 1);

555 }	559 }

OLD	NEW