Make DnsSocketPool copy RandIntCallback

Make DnsSocketPool copy RandIntCallback

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457
Committed: https://crrev.com/2dd66098349196a1048403810c0faadf05072387
Cr-Commit-Position: refs/heads/master@{#434752}

[Julia Tuttle, 2016-11-28 20:01:13]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[Julia Tuttle, 2016-11-28 20:02:21]

Description was changed from

==========
Make DnsSocketPool copy RandIntCallback

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

BUG=664457
==========

to

==========
Make DnsSocketPool copy RandIntCallback

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457
==========

[Julia Tuttle, 2016-11-28 20:02:43]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 20:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-11-28 20:05:42]

mmenke@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2016-11-28 20:05:42]

Wow, that is bad.  LGTM!

https://codereview.chromium.org/2533753003/diff/1/net/dns/dns_socket_pool.cc
File net/dns/dns_socket_pool.cc (right):

https://codereview.chromium.org/2533753003/diff/1/net/dns/dns_socket_pool.cc#...
net/dns/dns_socket_pool.cc:227: DnsSocketPool::~DnsSocketPool() {}
declaration order should match definition order.

[Julia Tuttle, 2016-11-28 20:10:25]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[Julia Tuttle, 2016-11-28 20:10:37]

https://codereview.chromium.org/2533753003/diff/1/net/dns/dns_socket_pool.cc
File net/dns/dns_socket_pool.cc (right):

https://codereview.chromium.org/2533753003/diff/1/net/dns/dns_socket_pool.cc#...
net/dns/dns_socket_pool.cc:227: DnsSocketPool::~DnsSocketPool() {}
On 2016/11/28 20:05:42, mmenke wrote:
> declaration order should match definition order.

Done.

[commit-bot: I haz the power, 2016-11-28 20:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julia Tuttle, 2016-11-28 21:35:32]

The CQ bit was unchecked by juliatuttle@chromium.org

[Julia Tuttle, 2016-11-28 21:35:41]

The CQ bit was checked by juliatuttle@chromium.org

[Julia Tuttle, 2016-11-28 21:35:42]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2533753003/#ps20001
(title: "Put methods in right order.")

[commit-bot: I haz the power, 2016-11-28 21:37:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:48:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480368941979360,
"parent_rev": "4407547fd30dbd739022e46032fcb6a7c80671bf", "commit_rev":
"5e3b3c9ea552128ec375aefc1323eac3bf39419e"}

[commit-bot: I haz the power, 2016-11-28 22:49:11]

Description was changed from

==========
Make DnsSocketPool copy RandIntCallback

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457
==========

to

==========
Make DnsSocketPool copy RandIntCallback

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457
==========

[commit-bot: I haz the power, 2016-11-28 22:49:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 22:52:41]

Description was changed from

==========
Make DnsSocketPool copy RandIntCallback

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457
==========

to

==========
Make DnsSocketPool copy RandIntCallback

DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).

Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.

Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.

(Also, rearrange destructor to satisfy the linter.)

BUG=664457

Committed: https://crrev.com/2dd66098349196a1048403810c0faadf05072387
Cr-Commit-Position: refs/heads/master@{#434752}
==========

[commit-bot: I haz the power, 2016-11-28 22:52:42]

Patchset 2 (id:??) landed as
https://crrev.com/2dd66098349196a1048403810c0faadf05072387
Cr-Commit-Position: refs/heads/master@{#434752}