Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2533713002:
Call OOM_CRASH when ArrayBuffer allocation fails (Closed)
DescriptionCall OOM_CRASH when ArrayBuffer allocation fails
BUG=None
Committed: https://crrev.com/95033a3ed5b5949ea9a59f818dd033f318e24538
Cr-Commit-Position: refs/heads/master@{#434653}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix #Messages
Total messages: 22 (14 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Call OOM_CRASH when ArrayBuffer allocation fails. BUG=None ========== to ========== Call OOM_CRASH when ArrayBuffer allocation fails BUG=None ==========
yhirano@chromium.org changed reviewers: + yukishiino@chromium.org
Hi, do you think this is a good change? context: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f... cc: tyoshino@
LGTM. https://codereview.chromium.org/2533713002/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h (right): https://codereview.chromium.org/2533713002/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h:134: if (!contents.data()) nit: We may want UNLIKELY? Not sure though.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2533713002/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h (right): https://codereview.chromium.org/2533713002/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h:134: if (!contents.data()) On 2016/11/28 08:30:36, Yuki wrote: > nit: We may want UNLIKELY? Not sure though. Done.
yhirano@chromium.org changed reviewers: + yutak@chromium.org
+yutak@ for OWNER review.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yukishiino@chromium.org Link to the patchset: https://codereview.chromium.org/2533713002/#ps20001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480337019354760,
"parent_rev": "f2d922c6bf1826e2f0feceb8190ae152f66bd3e1", "commit_rev":
"f79c30df4baa70dbd728672f92e8b1a96d7a7650"}
Message was sent while issue was closed.
Description was changed from ========== Call OOM_CRASH when ArrayBuffer allocation fails BUG=None ========== to ========== Call OOM_CRASH when ArrayBuffer allocation fails BUG=None ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Call OOM_CRASH when ArrayBuffer allocation fails BUG=None ========== to ========== Call OOM_CRASH when ArrayBuffer allocation fails BUG=None Committed: https://crrev.com/95033a3ed5b5949ea9a59f818dd033f318e24538 Cr-Commit-Position: refs/heads/master@{#434653} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/95033a3ed5b5949ea9a59f818dd033f318e24538 Cr-Commit-Position: refs/heads/master@{#434653} |
