Don't refer to removed spans when reformulating pasted content.

Don't refer to removed spans when reformulating pasted content.

ReplaceSelectionCommand::doApply repeatedly rewrites the DOM to fix up
the content it is inserting. One of those modifications--removing
redundant inline styles--may end up deleting the very span it is
tracking the insertion of.

This moves the node of interest into the InsertedNodes collection. As
the inserted nodes collection is modified, it adjusts the node of
interest to a surviving node.

BUG=668808
Committed: https://crrev.com/4e0fd330ee36ef618fba35a0dc9e0b3d5b5dce3f
Cr-Commit-Position: refs/heads/master@{#434930}

[dominicc (has gone to gerrit), 2016-11-28 08:13:01]

dominicc@chromium.org changed reviewers:
+ yosin@chromium.org

[dominicc (has gone to gerrit), 2016-11-28 08:13:02]

PTAL

[dominicc (has gone to gerrit), 2016-11-28 08:13:08]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 08:13:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 09:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 09:21:00]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-11-29 02:04:22]

lgtm w/ small nit

Thanks for working on ReplaceSelectionCommand!
It is one of complex implementations in editing.

https://codereview.chromium.org/2533703002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
(right):

https://codereview.chromium.org/2533703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp:1542:
DCHECK(insertedNodes.refNode()->isConnected() == refNodeWasConnected);
nit: DCHECK_EQ(insertedNodes.refNode()->isConnected(), refNodeWasConnected) <<
insertedNode.refNode()

[dominicc (has gone to gerrit), 2016-11-29 05:28:00]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-11-29 05:28:00]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2533703002/#ps20001
(title: "Address nit.")

[commit-bot: I haz the power, 2016-11-29 05:28:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 08:30:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480397280115310,
"parent_rev": "ca070b9ef397c4be6a5ed2d2ac383c2df0469e3b", "commit_rev":
"f95371a7c75081cf1724aaffea9713d927cd0cee"}

[commit-bot: I haz the power, 2016-11-29 08:30:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 08:31:56]

Description was changed from

==========
Don't refer to removed spans when reformulating pasted content.

ReplaceSelectionCommand::doApply repeatedly rewrites the DOM to fix up
the content it is inserting. One of those modifications--removing
redundant inline styles--may end up deleting the very span it is
tracking the insertion of.

This moves the node of interest into the InsertedNodes collection. As
the inserted nodes collection is modified, it adjusts the node of
interest to a surviving node.

BUG=668808
==========

to

==========
Don't refer to removed spans when reformulating pasted content.

ReplaceSelectionCommand::doApply repeatedly rewrites the DOM to fix up
the content it is inserting. One of those modifications--removing
redundant inline styles--may end up deleting the very span it is
tracking the insertion of.

This moves the node of interest into the InsertedNodes collection. As
the inserted nodes collection is modified, it adjusts the node of
interest to a surviving node.

BUG=668808

Committed: https://crrev.com/4e0fd330ee36ef618fba35a0dc9e0b3d5b5dce3f
Cr-Commit-Position: refs/heads/master@{#434930}
==========

[commit-bot: I haz the power, 2016-11-29 08:31:57]

Patchset 2 (id:??) landed as
https://crrev.com/4e0fd330ee36ef618fba35a0dc9e0b3d5b5dce3f
Cr-Commit-Position: refs/heads/master@{#434930}