Added CSSPropertyAPI and CSS padding properties which implement this API

third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index cb27b6b55f89c8eb1707cfce2d21562dcd142272..a1b75b050e9901590e0cf44ebedf373821060906 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -40,6 +40,8 @@
 #include "core/css/parser/CSSParserIdioms.h"
 #include "core/css/parser/CSSPropertyParserHelpers.h"
 #include "core/css/parser/CSSVariableParser.h"
+#include "core/css/properties/CSSPaddingProperties.h"

[alancutter (OOO until 2018), 2016/11/29 06:54:04]

This include is not necessary. The core parser logic is being separated from
knowing about individual properties' implementations.

[aazzam, 2016/11/30 23:32:53]

done

+#include "core/css/properties/CSSPropertyDescriptor.h"
 #include "core/frame/UseCounter.h"
 #include "core/layout/LayoutTheme.h"
 #include "core/svg/SVGPathUtilities.h"
@@ -3425,6 +3427,18 @@ const CSSValue* CSSPropertyParser::parseSingleValue(
                                   m_range.peek().id());
     return consumeIdent(m_range);
   }
+
+  /* Gets the parsing function for our current property from the property API.
+     If it has been implemented, we call this function, otherwise we manually
+     parse

[alancutter (OOO until 2018), 2016/11/29 06:51:49]

Avoid manual line wrapping, let the formatting tool do it for you.

[aazzam, 2016/11/30 23:32:53]

done

+     this value in the switch statement below. As we implement APIs for other
+     properties,
+     those properties will be taken out of the switch statement. */

[alancutter (OOO until 2018), 2016/11/29 06:51:49]

Style guide says to use /**/ or // consistently. These should use // for
consistency.
Ditto this for all other parts of the patch.

[aazzam, 2016/11/30 23:32:53]

done

+  const CSSPropertyDescriptor& cssPropertyDesc =
+      CSSPropertyDescriptor::get(property);
+  if (cssPropertyDesc.m_isValidProperty)
+    return cssPropertyDesc.parseSingleValue(m_range, m_context);
+
   switch (property) {
     case CSSPropertyWillChange:
       return consumeWillChange(m_range);
@@ -3515,13 +3529,6 @@ const CSSValue* CSSPropertyParser::parseSingleValue(
       return consumeLengthOrPercent(m_range, m_context.mode(),
                                     ValueRangeNonNegative,
                                     UnitlessQuirk::Allow);
-    case CSSPropertyWebkitPaddingStart:
-    case CSSPropertyWebkitPaddingEnd:
-    case CSSPropertyWebkitPaddingBefore:
-    case CSSPropertyWebkitPaddingAfter:
-      return consumeLengthOrPercent(m_range, m_context.mode(),
-                                    ValueRangeNonNegative,
-                                    UnitlessQuirk::Forbid);
     case CSSPropertyClip:
       return consumeClip(m_range, m_context.mode());
     case CSSPropertyTouchAction: