Added CSSPropertyAPI and CSS padding properties which implement this API

third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/CSSPropertyNames.h"
+#include "core/css/CSSValue.h"

[alancutter (OOO until 2018), 2016/11/29 06:51:50]

CSSValue can just be forward declared.

[aazzam, 2016/11/30 23:32:53]

done

+#include "core/css/properties/CSSPropertyAPI.h"
+
+namespace blink {
+
+/* This struct should contain function pointers matching those declared
+   in CSSPropertyAPI. API functions should also be added to the getDescriptor
+   template below. */
+struct CSSPropertyDescriptor {
+  const CSSValue* (*parseSingleValue)(CSSParserTokenRange&,
+                                      const CSSParserContext&);
+  CSSPropertyID (*getID)();

[alancutter (OOO until 2018), 2016/11/29 06:51:50]

Why is this a getter and not just "CSSPropertyID id"?

[aazzam, 2016/11/30 23:32:53]

done

+
+  bool m_isValidProperty;

[alancutter (OOO until 2018), 2016/11/29 06:51:50]

"m_" is for private class data members. For simple structs like this the "m_" is
not required.

I would rename this to isValid as well because it's about the descriptor rather
than the property.

[aazzam, 2016/11/30 23:32:54]

done

+  static const CSSPropertyDescriptor& get(CSSPropertyID);
+  static void add(CSSPropertyDescriptor, CSSPropertyID);

[alancutter (OOO until 2018), 2016/11/29 06:51:50]

Does this need to be exposed?

[aazzam, 2016/11/30 23:32:53]

get() is used in CSSPropertyParser so it needs to be exposed - i put a comment
in the code explaining this. I've moved add() outside of the struct :)

+};
+
+template <class T>
+CSSPropertyDescriptor getDescriptor() {
+  CSSPropertyDescriptor a;

[alancutter (OOO until 2018), 2016/11/29 06:51:50]

Avoid using names like "a" for objects with specific purposes/types. Name it
"descriptor".

[aazzam, 2016/11/30 23:32:53]

done

+  a.parseSingleValue = &T::parseSingleValue;
+  a.getID = &T::getID;
+
+  DCHECK(a.parseSingleValue != CSSPropertyAPI::parseSingleValue);
+  DCHECK(a.getID != CSSPropertyAPI::getID);
+
+  a.m_isValidProperty = true;
+  return a;
+}

[alancutter (OOO until 2018), 2016/11/29 06:51:50]

Does this need to be in the header file?

[aazzam, 2016/11/30 23:32:53]

as far as I know, templates do need to be in the header fine

+}