Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h

Issue 2533673002: Added CSSPropertyAPI and CSS padding properties which implement this API (Closed)
Patch Set: fixed comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CSSPropertyAPI_h
6 #define CSSPropertyAPI_h
7
8 #include "core/CSSPropertyNames.h"
9 #include "core/css/CSSValue.h"
10 #include "core/css/parser/CSSParserMode.h"
11 #include "core/css/parser/CSSParserTokenRange.h"
12
13 namespace blink {
14
15 // We will use this API to represent all functions used for property-specific
16 // logic inside the blink style engine. All specific properties are subclasses
17 // of CSSPropertyAPI.
18 //
19 // To add a new property using this API:
20 // - Make a class that implements CSSPropertyAPI, and implement the static
21 // methods.
22 // - Update the cssPropertyDescriptors array in CSSPropertyDescriptor.cpp to
23 // call GET_DESCRIPTOR(classname).
24 //
25 // To add new functions using this API:
26 // - New functions and static variables can be added in this class. A default
27 // implementation of functions can optionally be provided.
28 // - When adding new functions, also add them to GET_DESCRIPTOR, and the get()
29 // method in CSSPropertyDescriptors.cpp, and the descriptor struct in
30 // CSSPropertyDescriptor.h.
31 class CSSPropertyAPI {
32 STATIC_ONLY(CSSPropertyAPI);
33
34 public:
35 // A unique ID for the property.
36 // TODO(aazzam): Remove this once all callsites have been removed.
37 static const CSSPropertyID id;
Z_DONOTUSE 2016/12/08 01:00:18 Can we give this a less inviting name so that only
aazzam 2016/12/08 02:27:10 you're right, ID isn't read anywhere, I got rid of
38
39 // Parses a single CSS property and returns the corresponding CSSValue. If the
40 // input is invalid it returns nullptr.
41 static const CSSValue* parseSingleValue(CSSParserTokenRange&,
42 const CSSParserContext&);
43 };
44
45 } // namespace blink
46
47 #endif // CSSPropertyAPI_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698