Cleanup default FWL params part I

xfa/fwl/core/cfwl_pushbutton.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/cfwl_pushbutton.h"
 
 #include <memory>
 #include <utility>
@@ skipping 33 matching lines @@
   rect.Set(0, 0, 0, 0);
   if (!m_pProperties->m_pThemeProvider)
     m_pProperties->m_pThemeProvider = GetAvailableTheme();
 
   FX_FLOAT* fcaption =
       static_cast<FX_FLOAT*>(GetThemeCapacity(CFWL_WidgetCapacity::Margin));
   rect.Inflate(*fcaption, *fcaption);
   CFWL_Widget::GetWidgetRect(rect, true);
 }
 
-void CFWL_PushButton::SetStates(uint32_t dwStates, bool bSet) {
-  if ((dwStates & FWL_WGTSTATE_Disabled) && bSet) {
+void CFWL_PushButton::SetStates(uint32_t dwStates) {

[Tom Sepez, 2016/12/06 22:38:26]

sure this never got called as false?

[dsinclair, 2016/12/07 15:03:27]

That call would have been changed to a RemoveState at the call site. This code
doesn't do anything with a false other then proxy through to
CFWL_Widget::SetStates

+  if (dwStates & FWL_WGTSTATE_Disabled) {
     m_pProperties->m_dwStates = FWL_WGTSTATE_Disabled;
     return;
   }
-  CFWL_Widget::SetStates(dwStates, bSet);
+  CFWL_Widget::SetStates(dwStates);
 }
 
 void CFWL_PushButton::Update() {
   if (IsLocked())
     return;
   if (!m_pProperties->m_pThemeProvider)
     m_pProperties->m_pThemeProvider = GetAvailableTheme();
 
   UpdateTextOutStyles();
   GetClientRect(m_rtClient);
@@ skipping 231 matching lines @@
     return;
 
   CFWL_EvtMouse wmMouse;
   wmMouse.m_pSrcTarget = this;
   wmMouse.m_dwCmd = FWL_MouseCommand::LeftButtonUp;
   DispatchEvent(&wmMouse);
   CFWL_Event wmClick(CFWL_EventType::Click);
   wmClick.m_pSrcTarget = this;
   DispatchEvent(&wmClick);
 }