Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc

Issue 2533603002: [scheduler] Add options to TaskQueue::InsertFence (Closed)
Patch Set: More nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
index 83a2476b3a7e19a4ebb3569b508c7c78177d9092..177ed201dc3581bab3351e029fd7665d2990b23f 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
@@ -471,7 +471,7 @@ TEST_F(TaskQueueManagerTest, PendingDelayedTasksRemovedOnShutdown) {
TEST_F(TaskQueueManagerTest, InsertAndRemoveFence) {
Initialize(1u);
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
std::vector<EnqueueOrder> run_order;
// Posting a task when pumping is disabled doesn't result in work getting
@@ -523,7 +523,7 @@ TEST_F(TaskQueueManagerTest, DenyRunning_AfterRemovingFence) {
Initialize(1u);
std::vector<EnqueueOrder> run_order;
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
runners_[0]->SetQueueEnabled(false);
runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
@@ -538,7 +538,7 @@ TEST_F(TaskQueueManagerTest, DenyRunning_AfterRemovingFence) {
TEST_F(TaskQueueManagerTest, RemovingFenceWithDelayedTask) {
Initialize(1u);
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
std::vector<EnqueueOrder> run_order;
// Posting a delayed task when fenced will apply the delay, but won't cause
@@ -560,7 +560,7 @@ TEST_F(TaskQueueManagerTest, RemovingFenceWithDelayedTask) {
TEST_F(TaskQueueManagerTest, RemovingFenceWithMultipleDelayedTasks) {
Initialize(1u);
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
std::vector<EnqueueOrder> run_order;
// Posting a delayed task when fenced will apply the delay, but won't cause
@@ -587,7 +587,7 @@ TEST_F(TaskQueueManagerTest, RemovingFenceWithMultipleDelayedTasks) {
TEST_F(TaskQueueManagerTest, InsertFencePreventsDelayedTasksFromRunning) {
Initialize(1u);
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
std::vector<EnqueueOrder> run_order;
base::TimeDelta delay(base::TimeDelta::FromMilliseconds(10));
@@ -604,20 +604,20 @@ TEST_F(TaskQueueManagerTest, MultipleFences) {
std::vector<EnqueueOrder> run_order;
runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order));
test_task_runner_->RunUntilIdle();
EXPECT_THAT(run_order, ElementsAre(1, 2));
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
test_task_runner_->RunUntilIdle();
EXPECT_THAT(run_order, ElementsAre(1, 2, 3));
}
TEST_F(TaskQueueManagerTest, InsertFenceThenImmediatlyRemoveDoesNotBlock) {
Initialize(1u);
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
runners_[0]->RemoveFence();
std::vector<EnqueueOrder> run_order;
@@ -630,7 +630,7 @@ TEST_F(TaskQueueManagerTest, InsertFenceThenImmediatlyRemoveDoesNotBlock) {
TEST_F(TaskQueueManagerTest, InsertFencePostThenRemoveDoesNotBlock) {
Initialize(1u);
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
std::vector<EnqueueOrder> run_order;
runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
@@ -643,11 +643,11 @@ TEST_F(TaskQueueManagerTest, InsertFencePostThenRemoveDoesNotBlock) {
TEST_F(TaskQueueManagerTest, MultipleFencesWithInitiallyEmptyQueue) {
Initialize(1u);
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
std::vector<EnqueueOrder> run_order;
runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
test_task_runner_->RunUntilIdle();
EXPECT_THAT(run_order, ElementsAre(1));
@@ -657,14 +657,14 @@ TEST_F(TaskQueueManagerTest, BlockedByFence) {
Initialize(1u);
EXPECT_FALSE(runners_[0]->BlockedByFence());
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
EXPECT_TRUE(runners_[0]->BlockedByFence());
runners_[0]->RemoveFence();
EXPECT_FALSE(runners_[0]->BlockedByFence());
runners_[0]->PostTask(FROM_HERE, base::Bind(&NopTask));
- runners_[0]->InsertFence();
+ runners_[0]->InsertFence(TaskQueue::InsertFencePosition::NOW);
EXPECT_FALSE(runners_[0]->BlockedByFence());
test_task_runner_->RunUntilIdle();
@@ -1198,8 +1198,8 @@ TEST_F(TaskQueueManagerTest, SequenceNumSetWhenTaskIsPosted) {
// The sequence numbers are a one-based monotonically incrememting counter
// which should be set when the task is posted rather than when it's enqueued
- // onto the Incoming queue.
- EXPECT_THAT(observer.sequence_numbers(), ElementsAre(4, 3, 2, 1));
+ // onto the Incoming queue. This counter starts with 2.
+ EXPECT_THAT(observer.sequence_numbers(), ElementsAre(5, 4, 3, 2));
manager_->RemoveTaskObserver(&observer);
}

Powered by Google App Engine
This is Rietveld 408576698