[scheduler] Add options to TaskQueue::InsertFence

third_party/WebKit/public/platform/scheduler/base/task_queue.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_BASE_TASK_QUEUE_H_
 #define THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_BASE_TASK_QUEUE_H_
 
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/optional.h"
@@ skipping 154 matching lines @@
   virtual void SetBlameContext(
       base::trace_event::BlameContext* blame_context) = 0;
 
   // Removes the task queue from the previous TimeDomain and adds it to
   // |domain|.  This is a moderately expensive operation.
   virtual void SetTimeDomain(TimeDomain* domain) = 0;
 
   // Returns the queue's current TimeDomain.  Can be called from any thread.
   virtual TimeDomain* GetTimeDomain() const = 0;
 
+  enum class InsertFencePosition {
+    NOW,

[alex clarke (OOO till 29th), 2016/11/25 16:20:49]

I'm thinking ahead in case we ever add a third value so I'd suggest changing the
comments like so:

NOW,  // Tasks posted on the queue up till this point, and no further may run.

BEGINNING_OF_TIME,  // No tasks posted on this queue may run.

// Inserts a barrier into the task queue which prevents tasks with an enqueue
order
// greater the fence from running until either the fence has been removed or a
// subsequent fence has unblocked some tasks within the queue.
// Note delayed tasks, get their enqueue order set once their delay has expired,
// and non-delayed tasks get their enqueue order set when posted.

[altimin, 2016/11/25 16:59:26]

Done.

+    BEGINNING_OF_TIME,
+  };
+
   // Inserts a barrier into the task queue which inhibits non-delayed tasks
-  // posted after this point, or delayed tasks which are not yet ready to run,
-  // from being executed until the fence is cleared.  If a fence already existed
-  // the one supersedes it and previously blocked tasks will now run up until
-  // the new fence is hit.
-  virtual void InsertFence() = 0;
+  // posted after given point, or delayed tasks which are not yet ready to run,
+  // from being executed until the fence is cleared. If the fence is installed
+  // at the beginning of time, it will block all tasks in this queue,
+  // effectively disabling it.
+  //
+  // If a fence already existed the one supersedes it and previously blocked
+  // tasks will now run up until the new fence is hit.
+  virtual void InsertFence(InsertFencePosition position) = 0;
 
   // Removes any previously added fence and unblocks execution of any tasks
   // blocked by it.
   virtual void RemoveFence() = 0;
 
   virtual bool BlockedByFence() const = 0;
 
  protected:
   ~TaskQueue() override {}
 
   DISALLOW_COPY_AND_ASSIGN(TaskQueue);
 };
 
 }  // namespace scheduler
 }  // namespace blink
 
 #endif  // THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_BASE_TASK_QUEUE_H_