[scheduler] Add options to TaskQueue::InsertFence

third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TASK_QUEUE_IMPL_H_
 #define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TASK_QUEUE_IMPL_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 115 matching lines @@
   bool HasPendingImmediateWork() const override;
   base::Optional<base::TimeTicks> GetNextScheduledWakeUp() override;
   void SetQueuePriority(QueuePriority priority) override;
   QueuePriority GetQueuePriority() const override;
   void AddTaskObserver(base::MessageLoop::TaskObserver* task_observer) override;
   void RemoveTaskObserver(
       base::MessageLoop::TaskObserver* task_observer) override;
   void SetTimeDomain(TimeDomain* time_domain) override;
   TimeDomain* GetTimeDomain() const override;
   void SetBlameContext(base::trace_event::BlameContext* blame_context) override;
-  void InsertFence() override;
+  void InsertFence(InsertFencePosition position) override;
   void RemoveFence() override;
   bool BlockedByFence() const override;
 
   // If this returns false then future updates for this queue are not needed
   // unless requested.
   bool MaybeUpdateImmediateWorkQueues();
 
   const char* GetName() const override;
   QueueType GetQueueType() const override;
 
@@ skipping 39 matching lines @@
     main_thread_only().scheduled_time_domain_wakeup =
         scheduled_time_domain_wakeup;
   }
 
   HeapHandle heap_handle() const { return main_thread_only().heap_handle; }
 
   void set_heap_handle(HeapHandle heap_handle) {
     main_thread_only().heap_handle = heap_handle;
   }
 
+  // Returns true if queue is enabled and is not blocked by fence.
+  // Test-only and main-thread-only.
+  bool IsQueueUnblockedForTest() const;

[alex clarke (OOO till 29th), 2016/11/25 16:20:49]

minor: I'd slightly prefer a GetFenceForTest() and implement this as a helper in
the test.

Reason being a queue could be blocked by a fence with an value other than
BLOCKING_FENCE.

[altimin, 2016/11/25 16:59:25]

Done.

+
  private:
   friend class WorkQueue;
   friend class WorkQueueTest;
 
   enum class TaskType {
     NORMAL,
     NON_NESTABLE,
   };
 
   struct AnyThread {
@@ skipping 110 matching lines @@
   const bool should_report_when_execution_blocked_;
 
   DISALLOW_COPY_AND_ASSIGN(TaskQueueImpl);
 };
 
 }  // namespace internal
 }  // namespace scheduler
 }  // namespace blink
 
 #endif  // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TASK_QUEUE_IMPL_H_