tools/presubmit.py - Issue 2533583002: Presubmit should be able to handle files being deleted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/presubmit.py

Issue 2533583002: Presubmit should be able to handle files being deleted. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/presubmit.py

diff --git a/tools/presubmit.py b/tools/presubmit.py

index 553a5ae364152063391c04c6d879789664df205f..4dfa4e690a0bd8cc0813c5b9bde69ca0e7714810 100755

--- a/tools/presubmit.py

+++ b/tools/presubmit.py

@@ -179,7 +179,8 @@ class SourceFileProcessor(object):

all_files = [

f.AbsoluteLocalPath()

for f in files

- if (not self.IgnoreFile(f.LocalPath()) and

+ if (os.path.isfile(f.AbsoluteLocalPath()) and

+ not self.IgnoreFile(f.LocalPath()) and

self.IsRelevant(f.LocalPath()) and

all(not self.IgnoreDir(d) for d in dirs(f.LocalPath())) and

any(map(f.LocalPath().startswith, search_paths)))

« no previous file with comments | « no previous file | no next file » | no next file with comments »