[SubZero] Fix size of arguments on stack

[SubZero] Fix size of arguments on stack

This patch fixes size of arguments on stack

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8be69751c0300f5a35a064a71a4c2e385755065f

[jaydeep.patil, 2016-11-25 09:08:27]

Description was changed from

==========
[SubZero] Fix size of arguments on stack

This patch fixes size of arguments on stack
==========

to

==========
[SubZero] Fix size of arguments on stack

This patch fixes size of arguments on stack
==========

[jaydeep.patil, 2016-11-25 09:08:27]

jaydeep.patil@imgtec.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com,
makdstefan@gmail.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2016-11-25 14:58:02]

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:230: if (Dest &&
isVectorFloatingType(Dest->getType())) {
if (Dest != nullptr && ...)

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:240: // If PartialOnStack is true and if this is
a vector type
Reflow comment to 80-col

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:242: if (PartialOnStack == true &&
isVectorType(Ty)) {
if (PartialOnStack && ...)

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:252: OutArgsSizeBytes += MIPS32_MAX_GPR_ARG * 4;
Instead of "4", can you use something more symbolic/self-documenting?  like
(INT32_BITS/CHAR_BITS), or
  constexpr int BytesPerStackArg = 4;

[jaydeep.patil, 2016-11-28 03:08:36]

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:230: if (Dest &&
isVectorFloatingType(Dest->getType())) {
On 2016/11/25 14:58:02, Jim Stichnoth wrote:
> if (Dest != nullptr && ...)

Done.

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:240: // If PartialOnStack is true and if this is
a vector type
On 2016/11/25 14:58:02, Jim Stichnoth wrote:
> Reflow comment to 80-col

Done.

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:242: if (PartialOnStack == true &&
isVectorType(Ty)) {
On 2016/11/25 14:58:02, Jim Stichnoth wrote:
> if (PartialOnStack && ...)

Done.

https://codereview.chromium.org/2533563002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:252: OutArgsSizeBytes += MIPS32_MAX_GPR_ARG * 4;
On 2016/11/25 14:58:02, Jim Stichnoth wrote:
> Instead of "4", can you use something more symbolic/self-documenting?  like
> (INT32_BITS/CHAR_BITS), or
>   constexpr int BytesPerStackArg = 4;

Done.

[Jim Stichnoth, 2016-11-28 14:57:20]

lgtm

[Jim Stichnoth, 2016-11-28 14:57:29]

Description was changed from

==========
[SubZero] Fix size of arguments on stack

This patch fixes size of arguments on stack
==========

to

==========
[SubZero] Fix size of arguments on stack

This patch fixes size of arguments on stack

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-11-28 14:57:30]

Committed patchset #2 (id:20001) manually as
8be69751c0300f5a35a064a71a4c2e385755065f (presubmit successful).