Issue 2533533002: Prefer a driver to which the file is added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2533533002: Prefer a driver to which the file is added. (Closed)

Created:
4 years ago by scheglov

Modified:
4 years ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Prefer a driver to which the file is added. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/483fa6de3a68bfac30d221bd0da119ae7f71d9c6

Patch Set 1 #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	pkg/analysis_server/lib/src/analysis_server.dart	View		1 chunk	+11 lines, -4 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as 483fa6de3a68bfac30d221bd0da119ae7f71d9c6 (presubmit successful).

4 years ago (2016-11-25 17:28:14 UTC) #4

Brian Wilkerson

4 years ago (2016-11-28 16:43:32 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2533533002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2533533002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:592: * added if exists,
otherwise a driver in which the file was analyzed if
"if exists" --> "if one exists" (two places)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages