Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2533523002: Add Geolocation.PermissionState histogram. (Closed)
Patch Set: Address comments. Return to listed enums. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index a9ea94c896134d471021f918746648ac90b0dc91..dbe641832e5d5b8459da8abe0ee38f7d0a9db2df 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -18957,6 +18957,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Geolocation.Header.PermissionState"
+ enum="GeolocationHeaderPermissionState">
+ <owner>mvanouwerkerk@chromium.org</owner>
dominickn 2016/12/01 00:30:26 You can probably add kcarattini@ and myself as own
pdyson 2016/12/05 03:48:32 Done.
+ <summary>
+ Counts Geolocation requests for omnibox searches sliced by various
+ permission combinations.
+ </summary>
+</histogram>
+
<histogram name="Geolocation.InfoBarDelegate.Event"
enum="GeolocationInfoBarDelegateEvent">
<obsolete>
@@ -88270,6 +88279,136 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="32770" label="PDF"/>
</enum>
+<enum name="GeolocationHeaderPermissionState" type="int">
+ <int value="0"
+ label="Location mode high accuracy, app permission allowed, domain
+ permission allowed, location sent."/>
+ <int value="1"
+ label="Location mode high accuracy, app permission allowed, domain
+ permission allowed, location not sent."/>
+ <int value="2"
+ label="Location mode high accuracy, app permission allowed, domain
+ permission prompt, location sent."/>
+ <int value="3"
+ label="Location mode high accuracy, app permission allowed, domain
+ permission prompt, location not sent."/>
+ <int value="4"
+ label="Location mode high accuracy, app permission allowed, domain
+ permission denied."/>
+ <int value="5"
+ label="Location mode high accuracy, app permission prompt, domain
+ permission allowed."/>
+ <int value="6"
+ label="Location mode high accuracy, app permission prompt, domain
+ permission prompt."/>
+ <int value="7"
+ label="Location mode high accuracy, app permission prompt, domain
+ permission denied."/>
+ <int value="8"
+ label="Location mode high accuracy, app permission denied, domain
+ permission allowed."/>
+ <int value="9"
+ label="Location mode high accuracy, app permission denied, domain
+ permission prompt."/>
+ <int value="10"
+ label="Location mode high accuracy, app permission denied, domain
+ permission denied."/>
+ <int value="11"
+ label="Location mode battery saving, app permission allowed, domain
+ permission allowed, location sent."/>
+ <int value="12"
+ label="Location mode battery saving, app permission allowed, domain
+ permission allowed, location not sent."/>
+ <int value="13"
+ label="Location mode battery saving, app permission allowed, domain
+ permission prompt, location sent."/>
+ <int value="14"
+ label="Location mode battery saving, app permission allowed, domain
+ permission prompt, location not sent."/>
+ <int value="15"
+ label="Location mode battery saving, app permission allowed, domain
+ permission denied."/>
+ <int value="16"
+ label="Location mode battery saving, app permission prompt, domain
+ permission allowed."/>
+ <int value="17"
+ label="Location mode battery saving, app permission prompt, domain
+ permission prompt."/>
+ <int value="18"
+ label="Location mode battery saving, app permission prompt, domain
+ permission denied."/>
+ <int value="19"
+ label="Location mode battery saving, app permission denied, domain
+ permission allowed."/>
+ <int value="20"
+ label="Location mode battery saving, app permission denied, domain
+ permission prompt."/>
+ <int value="21"
+ label="Location mode battery saving, app permission denied, domain
+ permission denied."/>
+ <int value="22"
+ label="Location mode gps only, app permission allowed, domain
+ permission allowed, location sent."/>
+ <int value="23"
+ label="Location mode gps only, app permission allowed, domain
+ permission allowed, location not sent."/>
+ <int value="24"
+ label="Location mode gps only, app permission allowed, domain
+ permission prompt, location sent."/>
+ <int value="25"
+ label="Location mode gps only, app permission allowed, domain
+ permission prompt, location not sent."/>
+ <int value="26"
+ label="Location mode gps only, app permission allowed, domain
+ permission denied."/>
+ <int value="27"
+ label="Location mode gps only, app permission prompt, domain permission
+ allowed."/>
+ <int value="28"
+ label="Location mode gps only, app permission prompt, domain permission
+ prompt."/>
+ <int value="29"
+ label="Location mode gps only, app permission prompt, domain permission
+ denied."/>
+ <int value="30"
+ label="Location mode gps only, app permission denied, domain permission
+ allowed."/>
+ <int value="31"
+ label="Location mode gps only, app permission denied, domain permission
+ prompt."/>
+ <int value="32"
+ label="Location mode gps only, app permission denied, domain permission
+ denied."/>
+ <int value="33"
+ label="Location mode off, app permission allowed, domain permission
+ allowed."/>
+ <int value="34"
+ label="Location mode off, app permission allowed, domain permission
+ prompt."/>
+ <int value="35"
+ label="Location mode off, app permission allowed, domain permission
+ denied."/>
+ <int value="36"
+ label="Location mode off, app permission prompt, domain permission
+ allowed."/>
+ <int value="37"
+ label="Location mode off, app permission prompt, domain permission
+ prompt."/>
+ <int value="38"
+ label="Location mode off, app permission prompt, domain permission
+ denied."/>
+ <int value="39"
+ label="Location mode off, app permission denied, domain permission
+ allowed."/>
+ <int value="40"
+ label="Location mode off, app permission denied, domain permission
+ prompt."/>
+ <int value="41"
+ label="Location mode off, app permission denied, domain permission
+ denied."/>
+ <int value="42" label="Location mode unknown."/>
Ilya Sherman 2016/12/01 00:34:17 By the way, I didn't notice before: It's typically
pdyson 2016/12/05 03:48:32 Done.
+</enum>
+
<enum name="GeolocationInfoBarDelegateAndroidEvent" type="int">
<obsolete>
Deprecated 9/2014, and replaced by PermissionAction.
« chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698