chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java - Issue 2533523002: Add Geolocation.PermissionState histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

Issue 2533523002: Add Geolocation.PermissionState histogram. (Closed)

Patch Set: Address comments. Return to listed enums. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

index 2e3dbf1eb8df8fd9c41c049e28f7b5129ff8e1bd..33e101bf9975c361c8cb04cdd8496e3112eaee74 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

@@ -81,8 +81,8 @@ public class ChromeActionModeCallback implements ActionMode.Callback {

if (TextUtils.isEmpty(query)) return;

String url = TemplateUrlService.getInstance().getUrlForSearchQuery(query);

- String headers = GeolocationHeader.getGeoHeader(mContext.getApplicationContext(),

- url, mTab.isIncognito());

+ String headers =

+ GeolocationHeader.getGeoHeader(mContext.getApplicationContext(), url, mTab);

LoadUrlParams loadUrlParams = new LoadUrlParams(url);

loadUrlParams.setVerbatimHeaders(headers);