tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index a9ea94c896134d471021f918746648ac90b0dc91..de99ad1bced7823ec32bd3de10eb14a4b10cee5a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -19021,6 +19021,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="GeolocationHeader.PermissionState">

[Ilya Sherman, 2016/11/30 00:33:35]

Please add an enum attribute for this histogram.

[Ilya Sherman, 2016/11/30 00:33:35]

nit: Please group this with the existing Geolocation histograms, by inserting a
dot between "Geolocation" and "Header" (both here and in the Java code that
records this histogram).

[pdyson, 2016/11/30 08:00:43]

Done.

[pdyson, 2016/11/30 08:00:43]

Done. The labels for the enums are longer than one line. I suspect this will
cause a problem. Do I need to make them shorter?

[dominickn, 2016/12/01 00:30:26]

The labels definitely need to be shorter if possible, or else it makes reading
the histogram challenging. You could put more context in the summary to make it
clearer what's going on / explain shortenings. What about:

High acc., app allowed, domain denied, location sent
High acc., app allowed, domain denied, location not sent

etc.?

[pdyson, 2016/12/05 03:48:31]

Ok. I've made them shorter and explained the abbreviations in the description.

+  <owner>mvanouwerkerk@chromium.org</owner>

[Ilya Sherman, 2016/11/30 00:33:35]

Hmm, how did you choose Michael to be an owner for this histogram?  I notice
that he's not even reviewing this CL.  Is that intentional, or copy/pasta?

[pdyson, 2016/11/30 08:00:43]

I kept the same owner as the other Geolocation histograms. This is a starter
project for me, so I don't expect to continue working on this code. I'll cc
mvanouwerkerk@chromium.org and ask him who should own this.

+  <summary>
+    Counts Geolocation requests for each combination of location source, M+

[Ilya Sherman, 2016/11/30 00:33:35]

The phrase "M+ Chrome permission" is fairly confusing IMO -- I think "M+" refers
to Android versions, but that's not super obvious from the context here.  I'd
recommend either being more descriptive, or less -- the enum labels should
clarify what the exact breakdown is.  The summary is more intended to convey
what the overall metric's purpose is, and the precise conditions under which
it's recorded.

[pdyson, 2016/11/30 08:00:43]

Ok. I've made this shorter.

+    Chrome permission and Chrome omnibox permissions. For cases where a location
+    could not be sent the counts are further divided into whether the location
+    was sent or not.

[Ilya Sherman, 2016/11/30 00:33:35]

Hmm, what does it mean to divide cases "where a location could not be sent" into
"whether the location was sent"?  Should one of those phrases be something else?
 Or am I misreading this somehow?

[pdyson, 2016/11/30 08:00:43]

Acknowledged.

+  </summary>
+</histogram>
+
 <histogram name="GoogleNow.Card.Button.Clicked0" enum="GoogleNowCardTypeId">
   <owner>robliao@chromium.org</owner>
   <owner>skare@chromium.org</owner>