Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2533503002: Report decoded webfont blob size to memory-infra (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, drott, hiroshige
CC:
chromium-reviews, tyoshino+watch_chromium.org, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, danakj+watch_chromium.org, Nate Chapin, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report decoded webfont blob size to memory-infra Decoded webfonts are stored as SkData, and its backing store is malloc. (See WebFontDecoder::decode() for the implementation) Report them as a part of web_cache because FontResource is the owner of FontCustomPlatformData, which retains a reference to SkTypeface and SkData. BUG=668578 Committed: https://crrev.com/c33cef3224fde184a75ca9f79adc1a2f56ac3c14 Cr-Commit-Position: refs/heads/master@{#434486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M third_party/WebKit/Source/core/fetch/FontResource.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/WebFontDecoder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/WebFontDecoder.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
bashi
PTAL
4 years ago (2016-11-25 02:31:31 UTC) #4
haraken
LGTM on my side
4 years ago (2016-11-25 02:40:10 UTC) #5
drott
LGTM - it would be nice if you could add something like ", see WebFontDecoder.cpp" ...
4 years ago (2016-11-25 11:54:26 UTC) #8
bashi
The lifetime of Resource has changed recently and it's basically destroyed by Oilpan's GC if ...
4 years ago (2016-11-25 12:26:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533503002/1
4 years ago (2016-11-25 12:26:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 12:30:44 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-25 12:32:31 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c33cef3224fde184a75ca9f79adc1a2f56ac3c14
Cr-Commit-Position: refs/heads/master@{#434486}

Powered by Google App Engine
This is Rietveld 408576698