VR: Fix click during scrolling

chrome/browser/android/vr_shell/vr_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/vr_controller.h"
 
 #include <cmath>
 
 #include "base/logging.h"
 #include "base/time/time.h"
@@ skipping 184 matching lines @@
   }
   UpdateTouchInfo();
   UpdateGestureFromTouchInfo(gesture.get());
 
   if (gesture->type == WebInputEvent::Undefined &&
       IsButtonDown(gvr::kControllerButtonClick)) {
     gesture->type = WebInputEvent::GestureTapDown;
     gesture->data.tapDown.width = 0;
     gesture->data.tapDown.height = 0;
   }
+

[bshe, 2016/11/28 21:52:36]

nit: remove the empty line here.

[asimjour1, 2016/11/29 16:10:28]

Done.

   gesture->sourceDevice = blink::WebGestureDeviceTouchpad;
   gesture_list.push_back(std::move(gesture));
 
-  if (gesture_list.back()->type == WebInputEvent::GestureScrollEnd) {
+  if (state_ == SCROLLING && IsButtonDown(gvr::kControllerButtonClick)) {

[bshe, 2016/11/28 21:52:36]

nit: does it make sense to move this check into:
if (gesture_list.back()->type == WebInputEvent::GestureScrollEnd) statement?
It looks like with the new code, the type should be GestrueScrollEndfor both
Fling and TapDown? It would be easier for me to read the code.

[asimjour1, 2016/11/29 16:10:28]

Done.

+    std::unique_ptr<WebGestureEvent> tap_down(new WebGestureEvent());
+    tap_down->type = WebInputEvent::GestureTapDown;
+    tap_down->timeStampSeconds = gesture_list.back()->timeStampSeconds;
+    tap_down->sourceDevice = blink::WebGestureDeviceTouchpad;
+    tap_down->data.tapDown.width = 0;
+    tap_down->data.tapDown.height = 0;
+    gesture_list.push_back(std::move(tap_down));
+    Reset();
+  } else if (gesture_list.back()->type == WebInputEvent::GestureScrollEnd) {
     std::unique_ptr<WebGestureEvent> fling(new WebGestureEvent());
     fling->timeStampSeconds = gesture_list.back()->timeStampSeconds;
     fling->sourceDevice = blink::WebGestureDeviceTouchpad;
     fling->type = WebInputEvent::GestureFlingStart;
     if (IsHorizontalGesture()) {
       fling->data.flingStart.velocityX =
           overall_velocity_.x * kDisplacementScaleFactor;
     } else {
       fling->data.flingStart.velocityY =
           overall_velocity_.y * kDisplacementScaleFactor;
@@ skipping 42 matching lines @@
   }
 }
 
 void VrController::HandleDetectingState(WebGestureEvent* gesture) {
   // User lifts up finger from touch pad.
   if (touch_info_->touch_up || !(touch_info_->is_touching)) {
     Reset();
     return;
   }
 
-  // Touch position is changed and the touch point moves outside of slop.
+  // Touch position is changed, the touch point moves outside of slop,
+  // and the Controller's button is not down.
   if (UpdateCurrentTouchpoint() && touch_info_->is_touching &&
-      !InSlop(touch_info_->touch_point.position)) {
+      !InSlop(touch_info_->touch_point.position) &&
+      !IsButtonDown(gvr::kControllerButtonClick)) {
     state_ = SCROLLING;
     gesture->type = WebInputEvent::GestureScrollBegin;
     UpdateGesture(gesture);
     gesture->data.scrollBegin.deltaXHint =
         displacement_.x * kDisplacementScaleFactor;
     gesture->data.scrollBegin.deltaYHint =
         displacement_.y * kDisplacementScaleFactor;
   }
 }
 
 void VrController::HandleScrollingState(WebGestureEvent* gesture) {
   // Update current touch point.
   bool touch_position_changed = UpdateCurrentTouchpoint();
-  if (touch_info_->touch_up || !(touch_info_->is_touching)) {
+  if (touch_info_->touch_up || !(touch_info_->is_touching) ||
+      IsButtonDown(gvr::kControllerButtonClick)) {
     // Gesture ends.
     gesture->type = WebInputEvent::GestureScrollEnd;
     UpdateGesture(gesture);
   } else if (touch_position_changed) {
     // User continues scrolling and there is a change in touch position.
     gesture->type = WebInputEvent::GestureScrollUpdate;
     UpdateGesture(gesture);
     if (IsHorizontalGesture()) {
       gesture->data.scrollUpdate.deltaX =
           displacement_.x * kDisplacementScaleFactor;
@@ skipping 63 matching lines @@
   gvr::Vec2f velocity = Vector::ScalarMult(displacement, 1 / duration);
 
   float weight = duration / (kRC + duration);
 
   overall_velocity_ =
       Vector::Add(Vector::ScalarMult(overall_velocity_, 1 - weight),
                   Vector::ScalarMult(velocity, weight));
 }
 
 }  // namespace vr_shell