Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2533453002: [ObjC ARC] Converts ios/public/consumer/base:base to ARC.Automatically generated ARCMigrate commi… (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/public/consumer/base:base to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/6d6dd774e50cf758953a2606dc5904cddde5c799 Cr-Commit-Position: refs/heads/master@{#436281}

Patch Set 1 #

Total comments: 1

Patch Set 2 : mm/cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M ios/consumer/base/debugger.mm View 1 1 chunk +0 lines, -14 lines 0 comments Download
M ios/public/consumer/base/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
stkhapugin
ptal. passes downstream tests.
4 years ago (2016-11-25 09:48:57 UTC) #6
sdefresne
lgtm https://codereview.chromium.org/2533453002/diff/1/ios/public/consumer/base/BUILD.gn File ios/public/consumer/base/BUILD.gn (right): https://codereview.chromium.org/2533453002/diff/1/ios/public/consumer/base/BUILD.gn#newcode8 ios/public/consumer/base/BUILD.gn:8: "//ios/consumer/base/debugger.mm", This file should be a C++ file.
4 years ago (2016-11-25 10:12:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533453002/20001
4 years ago (2016-12-05 12:29:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 14:00:00 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6d6dd774e50cf758953a2606dc5904cddde5c799 Cr-Commit-Position: refs/heads/master@{#436281}
4 years ago (2016-12-05 14:02:13 UTC) #14
lpromero
4 years ago (2016-12-05 16:21:25 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2548313003/ by lpromero@chromium.org.

The reason for reverting is: The .cc is nowhere to be found..

Powered by Google App Engine
This is Rietveld 408576698