Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2533443002: fallback to null sink in WebAudioSourceProvider::Initialize() + UMA stats for device status (Closed)
Patch Set: content unittest fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index cd6091ddd3ccfcfc26d03a634d700428c75ac598..4a1866add2c891d10c9e4ee873e00f57cc681963 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -264,15 +264,8 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
// TODO(xhwang): When we use an external Renderer, many methods won't work,
// e.g. GetCurrentFrameFromCompositor(). See http://crbug.com/434861
-
- // Use the null sink if no valid sink was provided.
- audio_source_provider_ = new WebAudioSourceProviderImpl(
- params.audio_renderer_sink().get() &&
- params.audio_renderer_sink()
- ->GetOutputDeviceInfo()
- .device_status() == OUTPUT_DEVICE_STATUS_OK
- ? params.audio_renderer_sink()
- : new NullAudioSink(media_task_runner_));
+ audio_source_provider_ =
+ new WebAudioSourceProviderImpl(params.audio_renderer_sink(), media_log_);
}
WebMediaPlayerImpl::~WebMediaPlayerImpl() {

Powered by Google App Engine
This is Rietveld 408576698