Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: media/audio/audio_output_device.cc

Issue 2533443002: fallback to null sink in WebAudioSourceProvider::Initialize() + UMA stats for device status (Closed)
Patch Set: content unittest fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_device.cc
diff --git a/media/audio/audio_output_device.cc b/media/audio/audio_output_device.cc
index 2779174bfe06817f09970f4ccd82b2915b7ace93..ae88ddef593699471a3f16b92dd18455234abe6e 100644
--- a/media/audio/audio_output_device.cc
+++ b/media/audio/audio_output_device.cc
@@ -325,8 +325,11 @@ void AudioOutputDevice::OnDeviceAuthorized(
// different from OUTPUT_DEVICE_STATUS_OK, so the AudioOutputDevice
// will enter the IPC_CLOSED state anyway, which is the safe thing to do.
// This is preferable to holding a lock.
- if (!did_receive_auth_.IsSignaled())
+ if (!did_receive_auth_.IsSignaled()) {
device_status_ = device_status;
+ UMA_HISTOGRAM_ENUMERATION("Media.Audio.Render.OutputDeviceStatus",
+ device_status, OUTPUT_DEVICE_STATUS_MAX + 1);
+ }
if (device_status == OUTPUT_DEVICE_STATUS_OK) {
state_ = AUTHORIZED;

Powered by Google App Engine
This is Rietveld 408576698