Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: media/audio/audio_output_device.cc

Issue 2533443002: fallback to null sink in WebAudioSourceProvider::Initialize() + UMA stats for device status (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_device.cc
diff --git a/media/audio/audio_output_device.cc b/media/audio/audio_output_device.cc
index 0dcc76aca062b19bbdfb941088d053c1d1970ad3..43e8f8373cf3a012361acffa634d9ddb060a48bf 100644
--- a/media/audio/audio_output_device.cc
+++ b/media/audio/audio_output_device.cc
@@ -326,8 +326,11 @@ void AudioOutputDevice::OnDeviceAuthorized(
// different from OUTPUT_DEVICE_STATUS_OK, so the AudioOutputDevice
// will enter the IPC_CLOSED state anyway, which is the safe thing to do.
// This is preferable to holding a lock.
- if (!did_receive_auth_.IsSignaled())
+ if (!did_receive_auth_.IsSignaled()) {
device_status_ = device_status;
+ UMA_HISTOGRAM_ENUMERATION("Media.Audio.Render.OutputDeviceStatus",
DaleCurtis 2016/11/28 18:58:17 Isn't this always going to be timed out?
o1ka 2016/11/29 13:55:58 No, we are here when it's the first time we receiv
+ device_status, OUTPUT_DEVICE_STATUS_MAX + 1);
+ }
if (device_status == OUTPUT_DEVICE_STATUS_OK) {
state_ = AUTHORIZED;

Powered by Google App Engine
This is Rietveld 408576698