Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2533383002: Adjust the timestamp for VRDisplay.requestAnimationFrame calls (Closed)

Created:
4 years ago by bajones
Modified:
4 years ago
Reviewers:
klausw, cjgrant
CC:
chromium-reviews, blink-reviews, haraken, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust the timestamp for VRDisplay.requestAnimationFrame calls Previously timestamps had their origin incorrectly adjusted and were multiplied by 1000. BUG=669594 Committed: https://crrev.com/769c85525581f5f39cdc1d207b2254d35cb106f3 Cr-Commit-Position: refs/heads/master@{#435143}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 3 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
bajones
klausw@: Care to give me a sanity check here? Testing shows that the timestamps appear ...
4 years ago (2016-11-29 19:42:19 UTC) #2
cjgrant
https://codereview.chromium.org/2533383002/diff/1/third_party/WebKit/Source/modules/vr/VRDisplay.cpp File third_party/WebKit/Source/modules/vr/VRDisplay.cpp (right): https://codereview.chromium.org/2533383002/diff/1/third_party/WebKit/Source/modules/vr/VRDisplay.cpp#newcode53 third_party/WebKit/Source/modules/vr/VRDisplay.cpp:53: // Need to devide by 1000 here because serviceScriptedAnimations ...
4 years ago (2016-11-29 20:02:02 UTC) #4
klausw
LGTM with minor clarification request. FWIW, I'm not convinced that replacing m_navigatorVR->document() with m_vrDisplay->document() is ...
4 years ago (2016-11-29 20:50:27 UTC) #5
klausw
On 2016/11/29 20:50:27, klausw wrote: > LGTM with minor clarification request. > > FWIW, I'm ...
4 years ago (2016-11-29 20:52:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533383002/20001
4 years ago (2016-11-29 22:47:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-30 00:50:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533383002/20001
4 years ago (2016-11-30 07:24:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 07:53:53 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-30 07:56:22 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/769c85525581f5f39cdc1d207b2254d35cb106f3
Cr-Commit-Position: refs/heads/master@{#435143}

Powered by Google App Engine
This is Rietveld 408576698