Enabled/disable touch screen in TabletPowerButtonController

chrome/browser/chromeos/system/input_device_settings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/system/input_device_settings.h"
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
 #include "chrome/browser/profiles/profile_manager.h"
@@ skipping 226 matching lines @@
 void InputDeviceSettings::RegisterProfilePrefs(PrefRegistrySimple* registry) {
   registry->RegisterBooleanPref(::prefs::kTouchScreenEnabled, true);
   registry->RegisterBooleanPref(::prefs::kTouchPadEnabled, true);
 }
 
 void InputDeviceSettings::UpdateTouchDevicesStatusFromActiveProfilePrefs() {
   PrefService* user_prefs = GetActiveProfilePrefs();
   if (!user_prefs)
     return;
 
-  const bool touch_screen_status =
-      user_prefs->HasPrefPath(::prefs::kTouchScreenEnabled)
-          ? user_prefs->GetBoolean(::prefs::kTouchScreenEnabled)
-          : true;
+  const bool touch_screen_status = IsTouchscreenEnabled();

[Daniel Erat, 2016/11/30 22:58:07]

mind just inlining this in the SetTouchscreensEnabled() call below?

[Qiang(Joe) Xu, 2016/12/02 17:42:52]

Done.

 
   const bool touch_pad_status =
       user_prefs->HasPrefPath(::prefs::kTouchPadEnabled)
           ? user_prefs->GetBoolean(::prefs::kTouchPadEnabled)
           : true;
 
   SetTouchscreensEnabled(touch_screen_status);
   SetInternalTouchpadEnabled(touch_pad_status);
 }
 
-void InputDeviceSettings::ToggleTouchscreen() {
+bool InputDeviceSettings::IsTouchscreenEnabled() const {

[Daniel Erat, 2016/11/30 22:58:07]

mind renaming this to IsTouchscreenEnabledInPrefs() so it clearer that it isn't
referring to the same state as SetTouchscreensEnabled()?

[Qiang(Joe) Xu, 2016/12/02 17:42:52]

Done.

+  PrefService* user_prefs = GetActiveProfilePrefs();
+  if (!user_prefs)
+    return true;
+
+  return user_prefs->HasPrefPath(::prefs::kTouchScreenEnabled)
+             ? user_prefs->GetBoolean(::prefs::kTouchScreenEnabled)
+             : true;
+}
+
+void InputDeviceSettings::SetTouchscreenEnabled(bool enabled) {
   PrefService* user_prefs = GetActiveProfilePrefs();
   if (!user_prefs)
     return;
 
-  const bool touch_screen_status =
-      user_prefs->HasPrefPath(::prefs::kTouchScreenEnabled)
-          ? user_prefs->GetBoolean(::prefs::kTouchScreenEnabled)
-          : true;
-
-  user_prefs->SetBoolean(::prefs::kTouchScreenEnabled, !touch_screen_status);
-  SetTouchscreensEnabled(!touch_screen_status);
+  user_prefs->SetBoolean(::prefs::kTouchScreenEnabled, enabled);
+  SetTouchscreensEnabled(enabled);
 }
 
 void InputDeviceSettings::ToggleTouchpad() {
   PrefService* user_prefs = GetActiveProfilePrefs();
   if (!user_prefs)
     return;
 
   const bool touch_pad_status =
       user_prefs->HasPrefPath(::prefs::kTouchPadEnabled)
           ? user_prefs->GetBoolean(::prefs::kTouchPadEnabled)
           : true;
 
   user_prefs->SetBoolean(::prefs::kTouchPadEnabled, !touch_pad_status);
   SetInternalTouchpadEnabled(!touch_pad_status);
 }
 
 }  // namespace system
 }  // namespace chromeos