Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2533353003: [turbofan] Add size DCHECK for inline allocations. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add size DCHECK for inline allocations. This ensure that all inline allocations generated by {JSCreateLowering} will fit into a regular heap page. Allocations targeting LO-space must be done via a slower runtime call. R=bmeurer@chromium.org BUG=chromium:669850 Committed: https://crrev.com/8242966399837081e6e77456dc47ff3b1bef55a1 Cr-Commit-Position: refs/heads/master@{#41412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M src/compiler/js-create-lowering.cc View 2 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
4 years ago (2016-11-30 15:09:43 UTC) #3
Benedikt Meurer
Thanks, LGTM.
4 years ago (2016-12-01 05:35:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533353003/1
4 years ago (2016-12-01 09:20:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 09:22:07 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 09:22:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8242966399837081e6e77456dc47ff3b1bef55a1
Cr-Commit-Position: refs/heads/master@{#41412}

Powered by Google App Engine
This is Rietveld 408576698