Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(87)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/resources/close-context-messageport-crash-iframe.html
Issue
2533323003
:
Messaging: Fix crash when MessagePort is closed while messages are queued (Closed)
Patch Set: rm undeeded dcheck
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/fast/workers/close-context-messageport-crash.html
third_party/WebKit/LayoutTests/fast/workers/resources/close-context-messageport-crash-iframe.html
third_party/WebKit/Source/core/dom/MessagePort.cpp
View unified diff
|
Download patch
« third_party/WebKit/LayoutTests/fast/workers/close-context-messageport-crash.html
('K') |
« third_party/WebKit/LayoutTests/fast/workers/close-context-messageport-crash.html
('k') |
third_party/WebKit/Source/core/dom/MessagePort.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<meta charset="utf-8">
3
<title>crash when closing a MessagePort - iframe</title>
4
<script>
5
var worker = new SharedWorker(URL.createObjectURL(new Blob([
6
'onconnect = e => {' +
7
' for (let i = 0; i < 10; i++) { e.ports[0].postMessage({}); }' +
8
'};'
9
], {'type': 'text/javascript'})));
10
worker.port.onmessage = () => {
11
window.parent.done();
12
};
13
</script>
OLD
NEW
« third_party/WebKit/LayoutTests/fast/workers/close-context-messageport-crash.html
('K') |
« third_party/WebKit/LayoutTests/fast/workers/close-context-messageport-crash.html
('k') |
third_party/WebKit/Source/core/dom/MessagePort.cpp »
('j') |
no next file with comments »
Issue 2533323003: Messaging: Fix crash when MessagePort is closed while messages are queued (Closed)
Created 4 years ago by falken
Modified 4 years ago
Reviewers: nhiroki, haraken
Base URL:
Comments: 3
This is Rietveld
408576698