third_party/WebKit/LayoutTests/fast/workers/close-context-messageport-crash.html - Issue 2533323003: Messaging: Fix crash when MessagePort is closed while messages are queued

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/close-context-messageport-crash.html

Issue 2533323003: Messaging: Fix crash when MessagePort is closed while messages are queued (Closed)

Patch Set: rm undeeded dcheck Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>crash when closing a MessagePort with messages queued for dispatch</title >

	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <body>

	7 </body>

	8 <script>

	9 var resolve_done;

	10 let done_promise = new Promise(resolve => resolve_done = resolve);

	11

	12 function done() {

	13 document.querySelector('iframe').remove();

	14 resolve_done();

	15 }

	16

	17 // This test creates an iframe with a SharedWorker that does multiple

	18 // postMessages back to the iframe. Once a message is received, the

	19 // iframe is removed. The test passes if it does not crash

	20 // https://crbug.com/649616.
	nhiroki 2016/11/30 07:04:27 This is not for confirming web-exposed behavior, s This is not for confirming web-exposed behavior, so how about moving this to chromium/ directory? falken 2016/11/30 07:30:52 fast/workers/ was mostly written with just webkit/ Show quoted text On 2016/11/30 07:04:27, nhiroki (OOO until Dec 2) wrote: > This is not for confirming web-exposed behavior, so how about moving this to > chromium/ directory? fast/workers/ was mostly written with just webkit/blink in mind, it has a lot of gc and crash tests in it. So I'd rather keep it here for consistency. nhiroki 2016/11/30 07:52:52 Acknowledged. Show quoted text On 2016/11/30 07:30:52, falken wrote: > On 2016/11/30 07:04:27, nhiroki (OOO until Dec 2) wrote: > > This is not for confirming web-exposed behavior, so how about moving this to > > chromium/ directory? > > fast/workers/ was mostly written with just webkit/blink in mind, it has a lot of > gc and crash tests in it. So I'd rather keep it here for consistency. Acknowledged.
	21 promise_test(t => {

	22 const frame = document.createElement('iframe');

	23 frame.src = 'resources/close-context-messageport-crash-iframe.html';

	24 document.body.appendChild(frame);

	25 return done_promise;

	26 }, 'closing a MessagePort with messages queued for dispatch should not crash');

	27 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/workers/resources/close-context-messageport-crash-iframe.html » ('j') | no next file with comments »