runtime/bin/socket.h - Issue 2533303005: VM: Fix memory leak during shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket.h

Issue 2533303005: VM: Fix memory leak during shutdown (Closed)

Patch Set: Simplify socket.cc by not updating hashmaps during shutdown Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket.h

diff --git a/runtime/bin/socket.h b/runtime/bin/socket.h

index 35d4acc870fa911e906958468097a506a7a5c2b6..1afc05e58a3bfbd6ff6ee58365dbc21b17093b98 100644

--- a/runtime/bin/socket.h

+++ b/runtime/bin/socket.h

@@ -469,7 +469,7 @@ class ListeningSocketRegistry {

void InsertByFd(intptr_t fd, OSSocket* socket);

void RemoveByFd(intptr_t fd);

- bool CloseOneSafe(OSSocket* os_socket);

+ bool CloseOneSafe(OSSocket* os_socket, bool update_hash_maps);

void CloseAllSafe();

HashMap sockets_by_port_;

« no previous file with comments | « runtime/bin/hashmap_test.cc ('k') | runtime/bin/socket.cc » ('j') | no next file with comments »