Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: cipd/client/cipd/client.go

Issue 2533273006: Make log messages less annoying in no-update case. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cipd/client/cipd/client.go
diff --git a/cipd/client/cipd/client.go b/cipd/client/cipd/client.go
index 53bc31ad3efb18ef453457f29364c06d4a88164f..ae09c834c094172c1128d11a87b8de3aeee4caa1 100644
--- a/cipd/client/cipd/client.go
+++ b/cipd/client/cipd/client.go
@@ -773,7 +773,6 @@ func (client *clientImpl) maybeUpdateClient(ctx context.Context, fs local.FileSy
client.BeginBatch(ctx)
defer client.EndBatch(ctx)
- logging.Infof(ctx, "cipd: maybe updating client to version %q", targetVersion)
if pin, err = client.ResolveVersion(ctx, clientPackage, targetVersion); err != nil {
return
}
@@ -790,7 +789,11 @@ func (client *clientImpl) maybeUpdateClient(ctx context.Context, fs local.FileSy
return
}
- logging.Infof(ctx, "cipd: updating client to %s", pin)
+ if targetVersion == pin.InstanceID {
+ logging.Infof(ctx, "cipd: updating client to %s", pin)
+ } else {
+ logging.Infof(ctx, "cipd: updating client to %s (%s)", pin, targetVersion)
+ }
info, err := client.remote.fetchClientBinaryInfo(ctx, pin)
if err != nil {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698