Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2533263002: [turbofan] Teach escape analysis about ConvertTaggedHoleToUndefined. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Tobias Tebbi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Teach escape analysis about ConvertTaggedHoleToUndefined. The EscapeStatusAnalysis didn't know anything about the simplified operator ConvertTaggedHoleToUndefined, thus leading to a crash. We now just handled it by pretending that any allocation that goes into such a node escapes. BUG=chromium:669451 R=tebbi@chromium.org Committed: https://crrev.com/d6752d94a8c854accb776f185a5f7d683849355a Cr-Commit-Position: refs/heads/master@{#41359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-669451.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
4 years ago (2016-11-29 12:37:14 UTC) #1
Benedikt Meurer
Hey Tobias, Here's a trivial fix for the ConvertTaggedHoleToUndefined problem in escape analysis. Please take ...
4 years ago (2016-11-29 12:38:01 UTC) #4
Tobias Tebbi
On 2016/11/29 12:38:01, Benedikt Meurer wrote: > Hey Tobias, > > Here's a trivial fix ...
4 years ago (2016-11-29 13:11:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533263002/1
4 years ago (2016-11-29 13:11:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 13:13:35 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 13:14:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6752d94a8c854accb776f185a5f7d683849355a
Cr-Commit-Position: refs/heads/master@{#41359}

Powered by Google App Engine
This is Rietveld 408576698