Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2533243002: Update base::scoped_refptr<> docs (Closed)

Created:
4 years ago by Thiemo Nagel
Modified:
4 years ago
Reviewers:
danakj
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update base::scoped_refptr<> docs chromium-style enforces a private or protected destructor for classes that derive from RefCounted<> which in turn makes it necessary to add a friend declaration for RefCounted<>. BUG=none Committed: https://crrev.com/55b05a8ae594e2e8d49c7e6da64bbea51df7a76f Cr-Commit-Position: refs/heads/master@{#435516}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/memory/ref_counted.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Thiemo Nagel
Hi Dana, could you please take a look at this small update? Thank you, Thiemo
4 years ago (2016-11-29 11:06:32 UTC) #2
danakj
Thanks, just style fix for comment (even comments inside comments) https://codereview.chromium.org/2533243002/diff/1/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/2533243002/diff/1/base/memory/ref_counted.h#newcode228 ...
4 years ago (2016-11-30 00:00:08 UTC) #3
Thiemo Nagel
Thank you! Could you please take another look? https://codereview.chromium.org/2533243002/diff/1/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/2533243002/diff/1/base/memory/ref_counted.h#newcode228 base/memory/ref_counted.h:228: // ...
4 years ago (2016-11-30 10:41:24 UTC) #4
danakj
LGTM
4 years ago (2016-11-30 23:17:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533243002/20001
4 years ago (2016-11-30 23:18:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 01:20:56 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/55b05a8ae594e2e8d49c7e6da64bbea51df7a76f Cr-Commit-Position: refs/heads/master@{#435516}
4 years ago (2016-12-01 01:23:59 UTC) #11
Thiemo Nagel
4 years ago (2016-12-01 09:30:00 UTC) #12
Message was sent while issue was closed.
On 2016/11/30 23:17:38, danakj wrote:
> LGTM

Thanks for ticking the box!
Thiemo

Powered by Google App Engine
This is Rietveld 408576698