Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 253323002: Reland r267170 "Use DiscardableMemoryManager on Android." (Closed)

Created:
6 years, 7 months ago by Philippe
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Reland r267170 "Use DiscardableMemoryManager on Android." This allows userspace (DiscardableMemoryManager) to control eviction of unlocked DiscardableMemory instances to prevent the process from running out of address space in cases of heavy use of unlocked DiscardableMemory. This also removes all the occurences of 'Android' from the ashmem allocator to allow it to be later used on ChromeOS. BUG=327516, 334996 TBR=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267211

Patch Set 1 : Original CL #

Patch Set 2 : Update BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -1183 lines) Patch
M base/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M base/base.gyp View 2 chunks +5 lines, -1 line 0 comments Download
M base/base.gypi View 2 chunks +8 lines, -2 lines 0 comments Download
M base/memory/discardable_memory.h View 2 chunks +1 line, -5 lines 0 comments Download
M base/memory/discardable_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/memory/discardable_memory_allocator_android.h View 1 chunk +0 lines, -70 lines 0 comments Download
D base/memory/discardable_memory_allocator_android.cc View 1 chunk +0 lines, -553 lines 0 comments Download
D base/memory/discardable_memory_allocator_android_unittest.cc View 1 chunk +0 lines, -303 lines 0 comments Download
M base/memory/discardable_memory_android.cc View 5 chunks +26 lines, -16 lines 0 comments Download
A + base/memory/discardable_memory_ashmem.h View 2 chunks +21 lines, -15 lines 0 comments Download
A base/memory/discardable_memory_ashmem.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A + base/memory/discardable_memory_ashmem_allocator.h View 2 chunks +47 lines, -24 lines 0 comments Download
A + base/memory/discardable_memory_ashmem_allocator.cc View 15 chunks +63 lines, -89 lines 0 comments Download
A + base/memory/discardable_memory_ashmem_allocator_unittest.cc View 12 chunks +85 lines, -69 lines 0 comments Download
M base/memory/discardable_memory_emulated.h View 2 chunks +3 lines, -2 lines 0 comments Download
M base/memory/discardable_memory_emulated.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M base/memory/discardable_memory_linux.cc View 2 chunks +1 line, -6 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 2 chunks +1 line, -6 lines 0 comments Download
M base/memory/discardable_memory_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_unittest.cc View 3 chunks +1 line, -5 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 7 months ago (2014-04-30 11:37:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/253323002/20001
6 years, 7 months ago (2014-04-30 11:38:58 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 11:42:20 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 11:42:21 UTC) #4
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 7 months ago (2014-04-30 12:08:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/253323002/30023
6 years, 7 months ago (2014-04-30 12:08:48 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 14:56:53 UTC) #7
Message was sent while issue was closed.
Change committed as 267211

Powered by Google App Engine
This is Rietveld 408576698