Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2533223004: Keep the old TimeToFirstScrollUpdateSwapBegin2 metrics until M56 is stable (Closed)

Created:
4 years ago by lanwei
Modified:
4 years ago
Reviewers:
Ilya Sherman, tdresser
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep the old TimeToFirstScrollUpdateSwapBegin2 metrics until M56 is stable. We should keep the old touch's and wheel's TimeToFirstScrollUpdateSwapBegin2 metrics with the new ones until new metrics is at stable, so we can keep the data continuous. BUG=669618 Committed: https://crrev.com/3dad54187991ac8ca25e8bd3116f110b1319e8df Cr-Commit-Position: refs/heads/master@{#435094}

Patch Set 1 #

Patch Set 2 : old metrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
lanwei
4 years ago (2016-11-29 19:50:55 UTC) #7
tdresser
We need to keep actually reporting this data, not just update histograms.xml.
4 years ago (2016-11-29 19:59:23 UTC) #8
lanwei
On 2016/11/29 19:59:23, tdresser wrote: > We need to keep actually reporting this data, not ...
4 years ago (2016-11-29 20:12:13 UTC) #11
lanwei
4 years ago (2016-11-29 20:12:19 UTC) #12
tdresser
LGTM, thanks.
4 years ago (2016-11-29 20:26:09 UTC) #13
Ilya Sherman
LGTM
4 years ago (2016-11-29 21:11:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533223004/20001
4 years ago (2016-11-29 21:30:05 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 22:27:21 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-29 22:39:16 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dad54187991ac8ca25e8bd3116f110b1319e8df
Cr-Commit-Position: refs/heads/master@{#435094}

Powered by Google App Engine
This is Rietveld 408576698